Skip to content

gh-126500: test_ssl: Don't stop ThreadedEchoServer on OSError in ConnectionHandler; rely on __exit__#126503

Merged
encukou merged 1 commit intopython:mainfrom
encukou:intermittent-ssl-failures-2
Nov 7, 2024
Merged

gh-126500: test_ssl: Don't stop ThreadedEchoServer on OSError in ConnectionHandler; rely on __exit__#126503
encukou merged 1 commit intopython:mainfrom
encukou:intermittent-ssl-failures-2

Conversation

@encukou
Copy link
Member

@encukou encukou commented Nov 6, 2024

If read() in the ConnectionHandler thread raises OSError (except ConnectionError), the ConnectionHandler shuts down the entire ThreadedEchoServer, preventing further connections.
It also does that for EPROTOTYPE in wrap_conn.

As far as I can see, this is done to avoid the server thread getting stuck, forgotten, in its accept loop. However, since 2011 (5b95eb9) the server is used as a context manager, and its __exit__ does stop() and join(). (I'm not sure if we always used with since that commit, but currently we do.)

Make sure that the context manager is used, and remove the server.stop() calls from ConnectionHandler.

Loading
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

skip news tests Tests in the Lib/test dir

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants