gh-145675: Raise SyntaxError when constants are used as an identifier#145690
Open
StanFromIreland wants to merge 1 commit intopython:mainfrom
Open
gh-145675: Raise SyntaxError when constants are used as an identifier#145690StanFromIreland wants to merge 1 commit intopython:mainfrom
SyntaxError when constants are used as an identifier#145690StanFromIreland wants to merge 1 commit intopython:mainfrom
Conversation
StanFromIreland
requested review from
Eclips4,
lysnikolaou,
pablogsal and
tomasr8
as code owners
Member
|
An indicated on the issue, I agree with the proposed change. |
encukou
reviewed
Mar 10, 2026
Comment on lines
947
to
948
| with self.assertRaisesRegex(ValueError, f"identifier field can't represent '{constant}' constant"): | ||
| compile(expr, "<test>", "eval") |
Member
There was a problem hiding this comment.
Here's the rub: when compiling an AST node, ValueError does make sense. And it would be nice for these two to be consistent.
Can't have all three.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.