Skip to content

[3.14] gh-145615: Fix mimalloc page leak in the free-threaded build (gh-145626)#145691

Merged
colesbury merged 1 commit intopython:3.14from
miss-islington:backport-d76df75-3.14
Mar 9, 2026
Merged

[3.14] gh-145615: Fix mimalloc page leak in the free-threaded build (gh-145626)#145691
colesbury merged 1 commit intopython:3.14from
miss-islington:backport-d76df75-3.14

Conversation

@miss-islington
Copy link
Contributor

@miss-islington miss-islington commented Mar 9, 2026

Fix three issues that caused mimalloc pages to be leaked until the
owning thread exited:

  1. In _PyMem_mi_page_maybe_free(), move pages out of the full queue
    when relying on QSBR to defer freeing the page. Pages in the full
    queue are never searched by mi_page_queue_find_free_ex(), so a page
    left there is unusable for allocations.

  2. Move _PyMem_mi_page_clear_qsbr() from _mi_page_free_collect() to
    _mi_page_thread_free_collect() where it only fires when all blocks
    on the page are free (used == 0). The previous placement was too
    broad: it cleared QSBR state whenever local_free was non-NULL, but
    _mi_page_free_collect() is called from non-allocation paths (e.g.,
    page visiting in mi_heap_visit_blocks) where the page is not being
    reused.

  3. In _PyMem_mi_page_maybe_free(), use the page's heap tld to find the
    correct thread state for QSBR list insertion instead of
    PyThreadState_GET(). During stop-the-world pauses, the function may
    process pages belonging to other threads, so the current thread
    state is not necessarily the owner of the page.
    (cherry picked from commit d76df75)

Co-authored-by: Sam Gross colesbury@gmail.com

…ythongh-145626)

Fix three issues that caused mimalloc pages to be leaked until the
owning thread exited:

1. In _PyMem_mi_page_maybe_free(), move pages out of the full queue
   when relying on QSBR to defer freeing the page. Pages in the full
   queue are never searched by mi_page_queue_find_free_ex(), so a page
   left there is unusable for allocations.

2. Move _PyMem_mi_page_clear_qsbr() from _mi_page_free_collect() to
   _mi_page_thread_free_collect() where it only fires when all blocks
   on the page are free (used == 0). The previous placement was too
   broad: it cleared QSBR state whenever local_free was non-NULL, but
   _mi_page_free_collect() is called from non-allocation paths (e.g.,
   page visiting in mi_heap_visit_blocks) where the page is not being
   reused.

3. In _PyMem_mi_page_maybe_free(), use the page's heap tld to find the
   correct thread state for QSBR list insertion instead of
   PyThreadState_GET(). During stop-the-world pauses, the function may
   process pages belonging to other threads, so the current thread
   state is not necessarily the owner of the page.
(cherry picked from commit d76df75f51e662fd15ebe00e107058841de94860)

Co-authored-by: Sam Gross <colesbury@gmail.com>
@bedevere-bot
Copy link

🤖 New build scheduled with the buildbot fleet by @colesbury for commit 2a3a642 🤖

Results will be shown at:

https://buildbot.python.org/all/#/grid?branch=refs%2Fpull%2F145691%2Fmerge

If you want to schedule another build, you need to add the 🔨 test-with-buildbots label again.

@bedevere-bot bedevere-bot removed the 🔨 test-with-buildbots Test PR w/ buildbots; report in status section label Mar 9, 2026
@colesbury colesbury merged commit ba1ea3a into python:3.14 Mar 9, 2026
83 of 91 checks passed
@miss-islington miss-islington deleted the backport-d76df75-3.14 branch March 9, 2026 18:18
meta-codesync bot pushed a commit to facebookincubator/cinder that referenced this pull request Mar 10, 2026
Summary:
Cherry-pick of python/cpython#145691

Fix three issues that caused mimalloc pages to be leaked until the
owning thread exited:

1. In _PyMem_mi_page_maybe_free(), move pages out of the full queue
   when relying on QSBR to defer freeing the page. Pages in the full
   queue are never searched by mi_page_queue_find_free_ex(), so a page
   left there is unusable for allocations.

2. Move _PyMem_mi_page_clear_qsbr() from _mi_page_free_collect() to
   _mi_page_thread_free_collect() where it only fires when all blocks
   on the page are free (used == 0). The previous placement was too
   broad: it cleared QSBR state whenever local_free was non-NULL, but
   _mi_page_free_collect() is called from non-allocation paths (e.g.,
   page visiting in mi_heap_visit_blocks) where the page is not being
   reused.

3. In _PyMem_mi_page_maybe_free(), use the page's heap tld to find the
   correct thread state for QSBR list insertion instead of
   PyThreadState_GET(). During stop-the-world pauses, the function may
   process pages belonging to other threads, so the current thread
   state is not necessarily the owner of the page.

Reviewed By: itamaro

Differential Revision: D95830120

fbshipit-source-id: 0367568aebe8ae20b6ba95b688be0a9242d9a772
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants