gh-145866: Convert CALL_INTRINSIC_1 to leave its inputs on the stack to be cleaned up by _POP_TOP.#145964
Conversation
Sacul0457
requested review from
Fidget-Spinner,
markshannon,
savannahostrowski and
tomasr8
as code owners
| @@ -0,0 +1 @@ | |||
| Convert ``CALL_INTRINSIC_1`` to leave its inputs on the stack to be cleaned up by ``_POP_TOP``. | |||
There was a problem hiding this comment.
nit: NEWS.d is not needed until this is affected to end-users.
…e-145866.1oBN2p.rst
Python/bytecodes.c
Outdated
| v = value; | ||
| DEAD(value); | ||
| if (res_o == NULL) { | ||
| ERROR_NO_POP(); | ||
| } |
There was a problem hiding this comment.
Sorry I made a mistake, I think v should only transfer ownership after the error branch.
|
A Python core developer has requested some changes be made to your pull request before we can consider merging it. If you could please address their requests along with any other requests in other reviews from core developers that would be appreciated. Once you have made the requested changes, please leave a comment on this pull request containing the phrase |
|
I have made the requested changes; please review again |
|
Thanks for making the requested changes! @Fidget-Spinner: please review the changes made to this pull request. |
4 participants
_POP_TOP#145866