Skip to content

bpo-38328: Speed up the creation time of constant list literals. #16498

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
brandtbucher wants to merge 7 commits into from
Closed

bpo-38328: Speed up the creation time of constant list literals. #16498

Show file tree
Hide file tree
Changes from 4 commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
0909161
Create all constant lists in one or two ops.
brandtbucher Sep 30, 2019
d53e48d
Fix failing test.
brandtbucher Sep 30, 2019
c37dc4e
📜🤖 Added by blurb_it.
blurb-it[bot] Sep 30, 2019
091e9cd
Regenerate importlib.
brandtbucher Sep 30, 2019
6ac735e
SS code review.
brandtbucher Oct 5, 2019
c5ad049
islist -> is_tuple
brandtbucher Oct 5, 2019
d0f4746
Fix copy/paste error.
brandtbucher Oct 5, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion Lib/test/test_sys.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1222,7 +1222,7 @@ def get_gen(): yield 1
# list
samples = [[], [1,2,3], ['1', '2', '3']]
for sample in samples:
check(sample, vsize('Pn') + len(sample)*self.P)
check(list(sample), vsize('Pn') + len(sample)*self.P)
Copy link
Copy Markdown
Member Author

@brandtbucher brandtbucher Sep 30, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a sys.getsizeof test. The 3-element lists are overallocated, so we resize them here.

# sortwrapper (list)
# XXX
# cmpwrapper (list)
Expand Down
1 change: 1 addition & 0 deletions Misc/NEWS.d/next/Core and Builtins/2019-09-30-17-03-59.bpo-38328.VLX3Gi.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
Sped up the creation time of constant :class:`list` literals. Patch by Brandt Bucher.
283 changes: 142 additions & 141 deletions Python/importlib_external.h
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Loading