bpo-39320: Handle unpacking of **values in compiler#18141
Merged
markshannon merged 6 commits intopython:masterfrom Jan 27, 2020
Merged
bpo-39320: Handle unpacking of **values in compiler#18141markshannon merged 6 commits intopython:masterfrom
markshannon merged 6 commits intopython:masterfrom
Conversation
Loading
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is the second part of the implementation of bpo-39320.
Part 1 was #17984
This PR replaces BUILD_MAP_UNPACK and BUILD_MAP_UNPACK_WITH_CALL
with DICT_MERGE and DICT_UPDATE.
DICT_UPDATE ncallsitem_n.update(tos)whereitem_nis thenth item on the stack andtosis popped from the stack.DICT_MERGE nis the same, but raises an exception if there are duplicate keys.https://bugs.python.org/issue39320