Skip to content

gh-98703: Fix asyncio proactor_events calling _call_connection_lost multiple times #98704

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Fidget-Spinner merged 4 commits into from
Oct 27, 2022
Merged

gh-98703: Fix asyncio proactor_events calling _call_connection_lost multiple times #98704

Show file tree
Hide file tree
Changes from 3 commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
f348542
Fix asyncio proactor_events calling _call_connection_lost multiple times
Fidget-Spinner Oct 26, 2022
5a3211e
📜🤖 Added by blurb_it.
blurb-it[bot] Oct 26, 2022
26dfd85
Apply suggestions by Kumar
Fidget-Spinner Oct 26, 2022
9a4b6f8
Apply suggestions again
Fidget-Spinner Oct 26, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion Lib/asyncio/proactor_events.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -152,6 +152,8 @@ def _force_close(self, exc):
self._loop.call_soon(self._call_connection_lost, exc)

def _call_connection_lost(self, exc):
if self._called_connection_lost:
return
try:
self._protocol.connection_lost(exc)
finally:
Expand All @@ -161,7 +163,6 @@ def _call_connection_lost(self, exc):
# cure it, but maybe using DisconnectEx() would be better.
if hasattr(self._sock, 'shutdown') and self._sock.fileno() != -1:
self._sock.shutdown(socket.SHUT_RDWR)
Comment thread
Fidget-Spinner marked this conversation as resolved.
self._sock.close()
Comment thread
Fidget-Spinner marked this conversation as resolved.
self._sock = None
server = self._server
if server is not None:
Expand Down
2 changes: 2 additions & 0 deletions Misc/NEWS.d/next/Library/2022-10-26-07-51-55.gh-issue-98703.0hW773.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,2 @@
Fix :meth:`asyncio.StreamWriter.drain` to call ``protocol.connection_lost``
callback only once on Windows.