Fix #2611: Deprecate ProvidedSponsorshipAssetsView#2929
Fix #2611: Deprecate ProvidedSponsorshipAssetsView#2929iampujan wants to merge 4 commits intopython:mainfrom
Conversation
There was a problem hiding this comment.
Pull request overview
Deprecates and removes the legacy ProvidedSponsorshipAssetsView endpoint/template now that “provided assets” are surfaced directly within SponsorshipDetailView (sponsorship_detail.html).
Changes:
- Removed
ProvidedSponsorshipAssetsViewand its URL route. - Deleted the legacy
sponsorship_assets_view.htmltemplate and removed the “View all assets” link from the sponsorship detail page. - Updated provided-asset
user_view_urlto point to the sponsorship detail page’s “Provided Assets” section.
Reviewed changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| apps/users/views.py | Removes the deprecated ProvidedSponsorshipAssetsView. |
| apps/users/urls.py | Removes the provided-assets/ route. |
| apps/users/templates/users/sponsorship_detail.html | Removes the link to the deleted provided-assets page. |
| apps/users/templates/users/sponsorship_assets_view.html | Deletes the deprecated template. |
| apps/sponsors/models/benefits.py | Updates user_view_url to deep-link to the provided-assets section on the sponsorship detail page. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 5 out of 5 changed files in this pull request and generated no new comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 5 out of 5 changed files in this pull request and generated 1 comment.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
iampujan
force-pushed
the
feature/issue-2611-deprecate-provided-assets-view
branch
from
bc076a2 to
ab8c75a
Compare
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 6 out of 6 changed files in this pull request and generated 2 comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 6 out of 6 changed files in this pull request and generated no new comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Deprecates
ProvidedSponsorshipAssetsViewas its functionality is now wholly covered bySponsorshipDetailView. The old template and url have been removed.