Skip to content

Completing functionality for enum.auto #1331

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
JelleZijlstra merged 6 commits into from
May 27, 2017
Merged

Completing functionality for enum.auto #1331

Changes from 4 commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
0413931
Completing functionality for enum.auto
mistermocha May 24, 2017
f2167ce
Update enum.pyi
mistermocha May 24, 2017
ae06a79
Update enum.pyi
mistermocha May 26, 2017
b74065a
Update enum.pyi
mistermocha May 26, 2017
bda7853
Runs just fine without `__init__`, removing
May 27, 2017
11eea09
fix indentation, remove redundant label
JelleZijlstra May 27, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion stdlib/3.4/enum.pyi
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,8 +32,10 @@ def unique(enumeration: _S) -> _S: ...
if sys.version_info >= (3, 6):
_auto_null = ... # type: Any

class auto:
class auto(IntFlag):
Copy link
Copy Markdown
Member

@JelleZijlstra JelleZijlstra May 24, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you add a comment explaining why we're lying here? Maybe link to the mypy issue or PR.

Copy link
Copy Markdown
Contributor Author

@mistermocha mistermocha May 24, 2017 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

enum.IntFlag has all the right methods & properties to most closely match the behavior of anything returned by enum.auto()

Copy link
Copy Markdown
Member

@JelleZijlstra JelleZijlstra May 25, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you add that in the code itself?

Copy link
Copy Markdown
Contributor Author

@mistermocha mistermocha May 26, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done. I hope a docstring is apporopriate.

Copy link
Copy Markdown
Member

@gvanrossum gvanrossum May 26, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A comment is preferred. (Also, why is an __init__ needed?)

Copy link
Copy Markdown

@ghpqans ghpqans Jul 12, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As written in my comment, I don't think the comment is telling the truth but the inadvertent result of some misunderstanding. https://youtrack.jetbrains.com/issue/PY-53388/PyCharm-thinks-enumauto-needs-an-argument#focus=Comments-27-6301482.0-0

Copy link
Copy Markdown
Collaborator

@srittau srittau Jul 13, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If you think there are problems with how things are implemented, please open a new issue.

Copy link
Copy Markdown

@ghpqans ghpqans Jul 13, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Exists already: https://youtrack.jetbrains.com/issue/PY-53388/PyCharm-thinks-enumauto-needs-an-argument

Copy link
Copy Markdown
Member

@AlexWaygood AlexWaygood Jul 13, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please open a typeshed issue if you want typeshed people to do something about it.

"""auto: subclassing IntFlag so it picks up all implemented base functions, best modeling behavior of enum.auto()"""
value = ... # type: Any
def __init__(self) -> None: ...

class Flag(Enum):
def __contains__(self: _T, other: _T) -> bool: ...
Expand Down