Skip to content

Fix usage of byte2int with bytes #9152

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
AlexWaygood merged 5 commits into from
Nov 12, 2022
Merged

Fix usage of byte2int with bytes #9152

Changes from 2 commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
605b212
Fix usage of byte2int with bytes
Avasam Nov 10, 2022
385a363
Update comment
Avasam Nov 10, 2022
9b4261b
better solution
Avasam Nov 12, 2022
01c5e36
Merge branch 'main' into six-buffer-index
Avasam Nov 12, 2022
e0c0a9a
private _SupportsGetItem
Avasam Nov 12, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 6 additions & 1 deletion stubs/six/six/__init__.pyi
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -65,7 +65,12 @@ unichr = chr

def int2byte(i: int) -> bytes: ...

# Should be `byte2int: operator.itemgetter[int]`. But a bug in mypy prevents using TypeVar in itemgetter__call__
# This overload is temporary until typecheckers update their shipped version of typeshed
@overload
def byte2int(obj: bytes) -> int: ...

# Should be `byte2int: operator.itemgetter[int]`. But a bug in mypy prevents using TypeVar in itemgetter.__call__
@overload
def byte2int(obj: SupportsGetItem[int, _T]) -> _T: ...

indexbytes = operator.getitem
Expand Down