Skip to content

fix (Breadcrumb): Dropdown item, ellipsis & separator breaks <ol> list structure #693

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
paanSinghCoder merged 3 commits into from
Mar 20, 2026
Merged

fix (Breadcrumb): Dropdown item, ellipsis & separator breaks <ol> list structure #693

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
f9fbc51
fix: Dropdown item breaks <ol> list structure
paanSinghCoder Mar 11, 2026
fbfa80c
fix (breadcrumb): separator and ellipsis not in li
paanSinghCoder Mar 11, 2026
e61800c
Merge branch 'main' into fix/breadcrumb-li-structure-breaking
paanSinghCoder Mar 20, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion apps/www/src/components/playground/index.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,8 +30,8 @@ export * from './label-examples';
export * from './link-examples';
export * from './list-examples';
export * from './menu-examples';
export * from './number-field-examples';
export * from './menubar-examples';
export * from './number-field-examples';
export * from './popover-examples';
export * from './preview-card-examples';
export * from './radio-examples';
Expand Down
43 changes: 25 additions & 18 deletions packages/raystack/components/breadcrumb/breadcrumb-item.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -47,23 +47,29 @@ export const BreadcrumbItem = ({

if (dropdownItems) {
return (
<Menu>
<Menu.Trigger className={styles['breadcrumb-dropdown-trigger']}>
{label}
<ChevronDownIcon className={styles['breadcrumb-dropdown-icon']} />
</Menu.Trigger>
<Menu.Content className={styles['breadcrumb-dropdown-content']}>
{dropdownItems.map((dropdownItem, dropdownIndex) => (
<Menu.Item
key={dropdownItem.key ?? dropdownIndex}
className={styles['breadcrumb-dropdown-item']}
onClick={dropdownItem?.onClick}
>
{dropdownItem.label}
</Menu.Item>
))}
</Menu.Content>
</Menu>
<li className={cx(styles['breadcrumb-item'], className)}>
<Menu>
<Menu.Trigger
ref={ref as React.Ref<HTMLButtonElement>}
className={styles['breadcrumb-dropdown-trigger']}
{...(props as React.ButtonHTMLAttributes<HTMLButtonElement>)}
>
{label}
<ChevronDownIcon className={styles['breadcrumb-dropdown-icon']} />
</Menu.Trigger>
<Menu.Content className={styles['breadcrumb-dropdown-content']}>
{dropdownItems.map((dropdownItem, dropdownIndex) => (
<Menu.Item
key={dropdownItem.key ?? dropdownIndex}
className={styles['breadcrumb-dropdown-item']}
onClick={dropdownItem?.onClick}
>
{dropdownItem.label}
</Menu.Item>
))}
</Menu.Content>
</Menu>
</li>
);
}
return (
Expand All @@ -77,7 +83,8 @@ export const BreadcrumbItem = ({
),
href,
...props,
...renderedElement.props
...renderedElement.props,
ref
},
label
)}
Expand Down
34 changes: 28 additions & 6 deletions packages/raystack/components/breadcrumb/breadcrumb-misc.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,14 +8,25 @@ import styles from './breadcrumb.module.css';
export interface BreadcrumbEllipsisProps extends ComponentProps<'span'> {}

export const BreadcrumbEllipsis = ({
ref,
className,
children = <DotsHorizontalIcon width={20} height={20} />,
...props
}: BreadcrumbEllipsisProps) => {
return (
<span className={cx(styles['breadcrumb-ellipsis'], className)} {...props}>
{children}
</span>
<li
className={styles['breadcrumb-item']}
role='presentation'
aria-hidden='true'
>
<span
className={cx(styles['breadcrumb-ellipsis'], className)}
ref={ref}
{...props}
>
{children}
</span>
</li>
);
};

Expand All @@ -24,14 +35,25 @@ BreadcrumbEllipsis.displayName = 'Breadcrumb.Ellipsis';
export interface BreadcrumbSeparatorProps extends ComponentProps<'span'> {}

export const BreadcrumbSeparator = ({
ref,
children = <ChevronRightIcon width={12} height={12} />,
className,
...props
}: BreadcrumbSeparatorProps) => {
return (
<span className={cx(styles['breadcrumb-separator'], className)} {...props}>
{children}
</span>
<li
className={styles['breadcrumb-item']}
role='presentation'
aria-hidden='true'
>
<span
className={cx(styles['breadcrumb-separator'], className)}
ref={ref}
{...props}
>
{children}
</span>
</li>
);
};

Expand Down
Loading