refactor: standardize className merging with cx#732
Conversation
Replace template-literal className concatenation in button, callout, and menu trigger with class-variance-authority cx() to keep class merging consistent across components without changing behavior. Made-with: Cursor
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (1)
✅ Files skipped from review due to trivial changes (1)
📝 WalkthroughWalkthroughThe pull request refactors CSS class composition across three components in the Raystack package. The Sequence Diagram(s)(omitted — changes are localized class-name composition updates without multi-component sequential flows) Possibly related issues
Suggested reviewers
🚥 Pre-merge checks | ✅ 2 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (2 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Replaced the use of cx() for className concatenation with a direct call to callout() to standardize class merging in the Callout component, ensuring consistency across components.
Summary
cx()inButton,Callout, andMenuTriggercximports fromclass-variance-authoritywhere neededTest plan
Made with Cursor