Skip to content

feat(compass): entity system proto definitions#461

Merged
ravisuhag merged 2 commits intomainfrom
feat/entity-system
Mar 29, 2026
Merged

feat(compass): entity system proto definitions#461
ravisuhag merged 2 commits intomainfrom
feat/entity-system

Conversation

@ravisuhag
Copy link
Copy Markdown
Member

@ravisuhag ravisuhag commented Mar 29, 2026

Summary

  • Rewrote Compass proto definitions for entity system
  • Removed all deprecated RPCs: assets, discussions, comments, tags, tag templates, lineage, probes
  • Added 16 new RPCs: Entity CRUD (7), Context/Impact (2), Edge CRUD (3), Star (4), Namespace (4)
  • New messages: Entity, Edge with temporal fields (valid_from/valid_to)

Context

Companion PR to raystack/compass entity system rewrite. Compass is moving from a static asset catalog to a temporal entity graph with Postgres-native search.

RPCs

Domain RPCs
Entity GetAllEntities, GetEntityByID, UpsertEntity, DeleteEntity, SearchEntities, SuggestEntities, GetEntityTypes
Context GetEntityContext, GetEntityImpact
Edge UpsertEdge, GetEdges, DeleteEdge
Star StarEntity, UnstarEntity, GetUserStarredEntities, GetMyStarredEntities, GetMyStarredEntity, GetEntityStargazers
Namespace CreateNamespace, GetNamespace, UpdateNamespace, ListNamespaces

New entity system RPCs alongside existing asset RPCs:

Entity CRUD:
- GetAllEntities, GetEntityByID, UpsertEntity, DeleteEntity
- SearchEntities (keyword/semantic/hybrid modes)
- SuggestEntities, GetEntityTypes

Context & Impact:
- GetEntityContext: assembled context subgraph (entity + edges + related)
- GetEntityImpact: downstream blast radius analysis

Edge CRUD:
- UpsertEdge, GetEdges, DeleteEdge

New messages: Entity, Edge (with temporal valid_from/valid_to),
and all request/response types for the above RPCs.
Removed all deprecated RPCs and messages:
- Discussions (GetAllDiscussions, CreateDiscussion, etc.)
- Comments (CreateComment, GetAllComments, etc.)
- Tags (CreateTagAsset, GetTagByAssetAndTemplate, etc.)
- Tag Templates (CreateTagTemplate, GetTagTemplate, etc.)
- Asset CRUD (SearchAssets, UpsertAsset, GetAssetByID, etc.)
- Asset lineage (GetGraph)
- Asset probes (CreateAssetProbe)
- Asset version history

Retained and updated:
- Entity CRUD: GetAllEntities, GetEntityByID, UpsertEntity, DeleteEntity
- Entity Search: SearchEntities, SuggestEntities, GetEntityTypes
- Entity Context: GetEntityContext, GetEntityImpact
- Edge CRUD: UpsertEdge, GetEdges, DeleteEdge
- Star (updated for entities): StarEntity, UnstarEntity, etc.
- Namespace: CreateNamespace, GetNamespace, UpdateNamespace, ListNamespaces
@coderabbitai
Copy link
Copy Markdown

coderabbitai bot commented Mar 29, 2026

Caution

Review failed

Pull request was closed or merged during review

📝 Walkthrough

Walkthrough

The CompassService gRPC API was refactored to replace domain-specific RPCs with a unified, generic entity-based model. All Discussion, Comment, Asset, and Tag-related operations were removed. New RPCs were introduced for generic Entity CRUD operations (GetAllEntities, GetEntityByID, UpsertEntity, DeleteEntity), Entity search and suggestions, entity type discovery, relationship operations (GetEntityContext, GetEntityImpact), edge management (UpsertEdge, GetEdges, DeleteEdge), and entity-scoped starring operations. Corresponding message types were replaced with new Entity and Edge definitions. Namespace RPCs were retained. The import of google/protobuf/wrappers.proto was removed.

🚥 Pre-merge checks | ✅ 3
✅ Passed checks (3 passed)
Check name Status Explanation
Title check ✅ Passed The title 'feat(compass): v2 entity system proto definitions' accurately summarizes the main change: a rewrite of Compass proto definitions to implement a new v2 entity system.
Description check ✅ Passed The description provides a comprehensive overview of the changes, including the removal of deprecated RPCs, addition of 16 new RPCs organized by domain, new message types, and clear context about the shift to a temporal entity graph.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@ravisuhag ravisuhag merged commit eefb04d into main Mar 29, 2026
2 of 3 checks passed
@ravisuhag ravisuhag deleted the feat/entity-system branch March 29, 2026 07:15
@ravisuhag ravisuhag changed the title feat(compass): v2 entity system proto definitions feat(compass): entity system proto definitions Mar 29, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant