fix(frontier): remove deprecated org_id from GetBillingAccountRequest#466
Conversation
|
The latest Buf updates on your PR. Results from workflow Validate / validate (pull_request).
|
📝 WalkthroughWalkthroughThe Suggested reviewers
🚥 Pre-merge checks | ✅ 3✅ Passed checks (3 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Caution
Some comments are outside the diff and can’t be posted inline due to platform limitations.
⚠️ Outside diff range comments (1)
raystack/frontier/v1beta1/frontier.proto (1)
420-432:⚠️ Potential issue | 🟡 MinorCorrect use of
reservedfor removed field.The change correctly reserves field number 2 after removing the deprecated
org_idfield. This follows protobuf best practices for preventing accidental reuse.Note that
GetBillingAccountRequestis the only billing-related message removingorg_idcompletely; other billing request messages (UpdateBillingAccountRequest,DeleteBillingAccountRequest, etc.) still haveorg_idmarked as deprecated. This creates API inconsistency. Since this is a breaking change forGetBillingAccountRequest—clients sendingorg_idwill have it silently ignored—ensure all consumers have migrated off this field before releasing.🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed. In `@raystack/frontier/v1beta1/frontier.proto` around lines 420 - 432, GetBillingAccountRequest removed the org_id field and added "reserved 2", causing an inconsistent API compared to other billing messages (e.g., UpdateBillingAccountRequest, DeleteBillingAccountRequest) that still mark org_id as deprecated; either revert GetBillingAccountRequest to keep org_id as a deprecated string field (restore the org_id field declaration instead of reserved 2) to maintain backward-compatible behavior, or apply the same removal (reserve field number 2 and remove org_id) across all billing request messages so the change is consistent—update the proto for GetBillingAccountRequest and/or UpdateBillingAccountRequest/DeleteBillingAccountRequest accordingly and add release/migration notes for clients if you proceed with removal.
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Outside diff comments:
In `@raystack/frontier/v1beta1/frontier.proto`:
- Around line 420-432: GetBillingAccountRequest removed the org_id field and
added "reserved 2", causing an inconsistent API compared to other billing
messages (e.g., UpdateBillingAccountRequest, DeleteBillingAccountRequest) that
still mark org_id as deprecated; either revert GetBillingAccountRequest to keep
org_id as a deprecated string field (restore the org_id field declaration
instead of reserved 2) to maintain backward-compatible behavior, or apply the
same removal (reserve field number 2 and remove org_id) across all billing
request messages so the change is consistent—update the proto for
GetBillingAccountRequest and/or
UpdateBillingAccountRequest/DeleteBillingAccountRequest accordingly and add
release/migration notes for clients if you proceed with removal.
ℹ️ Review info
⚙️ Run configuration
Configuration used: Organization UI
Review profile: CHILL
Plan: Pro
Run ID: 83bdf9ef-5489-40ad-b7eb-521f97f22bdd
📒 Files selected for processing (1)
raystack/frontier/v1beta1/frontier.proto
Summary
org_idfield fromGetBillingAccountRequestin the Frontier protoreserved 2to prevent accidental reuse of the removed field number