Skip to content

fix(frontier): remove deprecated org_id from GetBillingAccountRequest#466

Merged
rohanchkrabrty merged 1 commit intomainfrom
fix-get-billing-account-validation
Apr 2, 2026
Merged

fix(frontier): remove deprecated org_id from GetBillingAccountRequest#466
rohanchkrabrty merged 1 commit intomainfrom
fix-get-billing-account-validation

Conversation

@rohanchkrabrty
Copy link
Copy Markdown
Contributor

Summary

  • Remove the deprecated org_id field from GetBillingAccountRequest in the Frontier proto
  • The org ID is already inferred from the billing account ID, making this field unnecessary
  • Add reserved 2 to prevent accidental reuse of the removed field number

@github-actions
Copy link
Copy Markdown

github-actions bot commented Apr 2, 2026

The latest Buf updates on your PR. Results from workflow Validate / validate (pull_request).

BuildFormatLintBreakingUpdated (UTC)
✅ passed⏩ skipped✅ passed✅ passedApr 2, 2026, 9:46 AM

@coderabbitai
Copy link
Copy Markdown

coderabbitai bot commented Apr 2, 2026

📝 Walkthrough

Walkthrough

The GetBillingAccountRequest message in the Frontier protobuf definition is being updated to remove the deprecated org_id field (tag 2). The field tag is now explicitly reserved to prevent future reuse of that field number. This change enforces stricter API contracts by eliminating a previously deprecated field that clients should no longer use.

Suggested reviewers

  • rohilsurana
  • rsbh
🚥 Pre-merge checks | ✅ 3
✅ Passed checks (3 passed)
Check name Status Explanation
Title check ✅ Passed The title clearly summarizes the main change: removing the deprecated org_id field from GetBillingAccountRequest in the Frontier proto.
Description check ✅ Passed The description is related to the changeset, explaining the rationale for removing the deprecated org_id field and the addition of the reserved field tag.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@rohanchkrabrty rohanchkrabrty requested review from whoAbhishekSah and removed request for paanSinghCoder April 2, 2026 09:46
Copy link
Copy Markdown

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Caution

Some comments are outside the diff and can’t be posted inline due to platform limitations.

⚠️ Outside diff range comments (1)
raystack/frontier/v1beta1/frontier.proto (1)

420-432: ⚠️ Potential issue | 🟡 Minor

Correct use of reserved for removed field.

The change correctly reserves field number 2 after removing the deprecated org_id field. This follows protobuf best practices for preventing accidental reuse.

Note that GetBillingAccountRequest is the only billing-related message removing org_id completely; other billing request messages (UpdateBillingAccountRequest, DeleteBillingAccountRequest, etc.) still have org_id marked as deprecated. This creates API inconsistency. Since this is a breaking change for GetBillingAccountRequest—clients sending org_id will have it silently ignored—ensure all consumers have migrated off this field before releasing.

🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed.

In `@raystack/frontier/v1beta1/frontier.proto` around lines 420 - 432,
GetBillingAccountRequest removed the org_id field and added "reserved 2",
causing an inconsistent API compared to other billing messages (e.g.,
UpdateBillingAccountRequest, DeleteBillingAccountRequest) that still mark org_id
as deprecated; either revert GetBillingAccountRequest to keep org_id as a
deprecated string field (restore the org_id field declaration instead of
reserved 2) to maintain backward-compatible behavior, or apply the same removal
(reserve field number 2 and remove org_id) across all billing request messages
so the change is consistent—update the proto for GetBillingAccountRequest and/or
UpdateBillingAccountRequest/DeleteBillingAccountRequest accordingly and add
release/migration notes for clients if you proceed with removal.
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.

Outside diff comments:
In `@raystack/frontier/v1beta1/frontier.proto`:
- Around line 420-432: GetBillingAccountRequest removed the org_id field and
added "reserved 2", causing an inconsistent API compared to other billing
messages (e.g., UpdateBillingAccountRequest, DeleteBillingAccountRequest) that
still mark org_id as deprecated; either revert GetBillingAccountRequest to keep
org_id as a deprecated string field (restore the org_id field declaration
instead of reserved 2) to maintain backward-compatible behavior, or apply the
same removal (reserve field number 2 and remove org_id) across all billing
request messages so the change is consistent—update the proto for
GetBillingAccountRequest and/or
UpdateBillingAccountRequest/DeleteBillingAccountRequest accordingly and add
release/migration notes for clients if you proceed with removal.

ℹ️ Review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: 83bdf9ef-5489-40ad-b7eb-521f97f22bdd

📥 Commits

Reviewing files that changed from the base of the PR and between dd903ff and 104fd42.

📒 Files selected for processing (1)
  • raystack/frontier/v1beta1/frontier.proto

@rohanchkrabrty rohanchkrabrty merged commit fcb776f into main Apr 2, 2026
3 checks passed
@rohanchkrabrty rohanchkrabrty deleted the fix-get-billing-account-validation branch April 2, 2026 10:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants