Skip to content

Handle null or undefined children#11

Merged
yiminghe merged 4 commits intoreact-component:masterfrom
gpoole:handle-null-undefined-children
Jul 5, 2016
Merged

Handle null or undefined children#11
yiminghe merged 4 commits intoreact-component:masterfrom
gpoole:handle-null-undefined-children

Conversation

@gpoole
Copy link
Contributor

@gpoole gpoole commented Jun 17, 2016

Handles cases where <Animate /> is declared like so:

<Animate>
  {undefined}
  <div key='example'></div>
</Animate>

I've verified this with a test and in my own case, but please let me know if there's any additional testing needed to make sure this doesn't cause problems?

Fixes #7.

@coveralls
Copy link

coveralls commented Jun 17, 2016

Coverage Status

Coverage decreased (-0.4%) to 74.182% when pulling 2f3e941 on gpoole:handle-null-undefined-children into e707fda on react-component:master.

});

it('does not fail with null/undefined children', (done) => {
ReactDOM.render(
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can you make a complete test?

check whether classnames are added correctly

@yiminghe
Copy link
Member

yiminghe commented Jul 5, 2016

ok, thanks

@yiminghe yiminghe merged commit 3e611db into react-component:master Jul 5, 2016
@coveralls
Copy link

Coverage Status

Coverage increased (+0.4%) to 74.912% when pulling 0a256c4 on gpoole:handle-null-undefined-children into e707fda on react-component:master.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants