Skip to content

feat: support forceRender prop to pre-render the listbox #1185

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
Pareder wants to merge 3 commits into from
+21 −4
Closed

feat: support forceRender prop to pre-render the listbox #1185

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
fced601
feat: support `forceRender` prop to pre-render the listbox
Pareder Dec 8, 2025
00b8e44
add tests
Pareder Dec 9, 2025
6b16fe0
Apply suggestion from @coderabbitai[bot]
yoyo837 Dec 9, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 5 additions & 2 deletions src/BaseSelect/index.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,7 @@ import type {
RenderDOMFunc,
RenderNode,
} from '../interface';
import type { RefTriggerProps } from '../SelectTrigger';
import type { RefTriggerProps, SelectTriggerProps } from '../SelectTrigger';
import SelectTrigger from '../SelectTrigger';
import { getSeparatedContent, isValidCount } from '../utils/valueUtil';
import Polite from './Polite';
Expand Down Expand Up @@ -129,7 +129,8 @@ export interface BaseSelectPrivateProps {

export type BaseSelectPropsWithoutPrivate = Omit<BaseSelectProps, keyof BaseSelectPrivateProps>;

export interface BaseSelectProps extends BaseSelectPrivateProps, React.AriaAttributes {
export interface BaseSelectProps
extends BaseSelectPrivateProps, React.AriaAttributes, Pick<SelectTriggerProps, 'forceRender'> {
// Style
className?: string;
style?: React.CSSProperties;
Expand Down Expand Up @@ -298,6 +299,7 @@ const BaseSelect = React.forwardRef<BaseSelectRef, BaseSelectProps>((props, ref)
placement,
builtinPlacements,
getPopupContainer,
forceRender,

// Focus
showAction = [],
Expand Down Expand Up @@ -774,6 +776,7 @@ const BaseSelect = React.forwardRef<BaseSelectRef, BaseSelectProps>((props, ref)
placement={placement}
builtinPlacements={builtinPlacements}
getPopupContainer={getPopupContainer}
forceRender={forceRender}
empty={emptyOptions}
onPopupVisibleChange={onTriggerVisibleChange}
onPopupMouseEnter={onPopupMouseEnter}
Expand Down
4 changes: 2 additions & 2 deletions src/SelectTrigger.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
import Trigger, { type TriggerRef } from '@rc-component/trigger';
import Trigger, { type TriggerRef, type TriggerProps } from '@rc-component/trigger';
import type { AlignType, BuildInPlacements } from '@rc-component/trigger/lib/interface';
import { clsx } from 'clsx';
import * as React from 'react';
Expand Down Expand Up @@ -53,7 +53,7 @@ export interface RefTriggerProps {
getPopupElement: () => HTMLDivElement;
}

export interface SelectTriggerProps {
export interface SelectTriggerProps extends Pick<TriggerProps, 'forceRender'> {
prefixCls: string;
children: React.ReactElement;
disabled: boolean;
Expand Down
Loading