fix: run-android device not found on change from deviceId to device

[High5Apps]

Summary:

• I have a script that uses npx react-native run-android --deviceId <deviceId>
• When upgrading to React Native 75, I started seeing the following deprecation warning (line link) when using the script mentioned above:

  warn The `deviceId` parameter is renamed to `device`. Please use the new `device` argument next time to avoid this warning.
  

• So I updated my script to use npx react-native run-android --device <deviceId>, to remove the deprecation warning. But then, instead of working as expected, I got the following error message (line link):

  error No Android device or emulator connected.
  

• This issue was introduced in chore(run-android): deprecate --deviceId in favour of --device #2377
• This PR fixes the error above, so that calling run-android with --device instead of --deviceId works as expected
• The root cause was that the if statement in line 229 was always false because deviceId was never present, since --deviceId flag was no longer used
• Basically this PR converts the remaining references to deviceId in runAndroid/index.ts to be device instead. Note that references to device.deviceId were unchanged to keep this PR as minimal as possible.

Test Plan:

1. Clone the repository and do all the required steps from the Contributing guide
2. Observe the current buggy behavior by running the following command

node /path/to/react-native-cli/packages/cli/build/bin.js run-android --device "<your_device_id>"

3. Apply this patch and rebuild
4. Re-run the command above and observe that the error is not shown, and that Android is built and run as expected
5. Run the command below to verify that this PR didn't cause any regressions to run-android --list-devices

node /path/to/react-native-cli/packages/cli/build/bin.js run-android --list-devices

Checklist

• Documentation is up to date to reflect these changes.
• Follows commit message convention described in CONTRIBUTING.md

[szymonrybczak]

good call! thanks for fixing 🙏 (and sorry for breaking 🙈)