breaking: Delete rawBody handling on /symbolicate endpoint#2637
Merged
thymikee merged 1 commit intoreact-native-community:mainfrom Apr 29, 2025
Merged
Conversation
3 tasks
c37f4da to
b3bb00e
Compare
thymikee
approved these changes
Apr 29, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This removes a longstanding hack that covered for a lack of JSON body parsing in Metro's
/symbolicateendpoint. We're now resolving this in facebook/metro#1475 — meaning this can be removed from CLI.Relevant changes:
Breaking: CLI will no longer intercept and populate
req.rawBodyon/symbolicaterequests. Clients MUST send the header'Content-Type': 'application/json'.Test Plan
yarn build.@react-native-community/cli-toolsand@react-native-community/cli-server-apiinto a local checkout ofreact-nativeviayarn link.0.82.2.@react-native-community/cli-server-api/src/index.tsfile innode_modules.✅ Correctly symbolicated thrown error
[Meta only] Also validated in D72063249.
Checklist
react-nativecheckout (instructions).