[Done] Translate: Design Principles#146
Merged
carburo merged 8 commits intoreactjs:masterfrom Feb 15, 2019
Merged
Conversation
Contributor
Author
elyalvarado
changed the title
carburo
requested changes
Feb 15, 2019
Member
carburo
left a comment
carburo
left a comment
There was a problem hiding this comment.
Hi, thank you! The review is ready. Most of it is reduced to a few typos. I also added heading ids, as described in the translation guide. Check it out.
Co-Authored-By: elyalvarado <elyalvarado@gmail.com>
Contributor
Author
|
@carburo, thanks for your review. I applied all of the suggested changes, it was a really long and complex article and even though I read it 3 times it was hard for me to spot any errors. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.