Conversation
Pulls in nodejs/node-addon-api@53f7cf1 which fixes nodejs/node-addon-api#1272. Fixes #5673.
|
I don't see how I could possibly have broken lint, given that I'm not touching any linted files... |
|
Actually, this also broke some integration tests, but that really shouldn't be possible either... 🤔 I may need some help debugging this. |
|
I agree, the lint error is on |
|
I'd say this is okay to merge. Since the windows build broke, the workflow has never gotten to run the integration tests. And I've only ever achieved green tests locally from my |
|
The node test results look as green as they've ever been on |
|
@kraenhansen I came to the same conclusion. I think this PR is just getting penalized for all the failures that have built up while we weren't running tests 😡 I'll merge as soon as you approve the PR 😃 |
Pulls in nodejs/node-addon-api@53f7cf1 which fixes nodejs/node-addon-api#1272.
Fixes #5673.