Skip to content

Upgrade to node-addon-api 6#5703

Merged
RedBeard0531 merged 1 commit intomainfrom
ms/naa-upgrade
Apr 5, 2023
Merged

Upgrade to node-addon-api 6#5703
RedBeard0531 merged 1 commit intomainfrom
ms/naa-upgrade

Conversation

@RedBeard0531
Copy link
Copy Markdown
Contributor

@cla-bot cla-bot Bot added the cla: yes label Apr 5, 2023
@RedBeard0531 RedBeard0531 marked this pull request as ready for review April 5, 2023 13:57
@RedBeard0531
Copy link
Copy Markdown
Contributor Author

I don't see how I could possibly have broken lint, given that I'm not touching any linted files...

@RedBeard0531
Copy link
Copy Markdown
Contributor Author

Actually, this also broke some integration tests, but that really shouldn't be possible either... 🤔

I may need some help debugging this.

@kraenhansen
Copy link
Copy Markdown
Contributor

I agree, the lint error is on packages/realm/src/schema/types.ts

@kraenhansen
Copy link
Copy Markdown
Contributor

kraenhansen commented Apr 5, 2023

I'd say this is okay to merge. Since the windows build broke, the workflow has never gotten to run the integration tests. And I've only ever achieved green tests locally from my kh/enable-all-tests branch.

@kraenhansen
Copy link
Copy Markdown
Contributor

The node test results look as green as they've ever been on main.

@RedBeard0531
Copy link
Copy Markdown
Contributor Author

@kraenhansen I came to the same conclusion. I think this PR is just getting penalized for all the failures that have built up while we weren't running tests 😡

I'll merge as soon as you approve the PR 😃

@RedBeard0531 RedBeard0531 merged commit c989d73 into main Apr 5, 2023
@RedBeard0531 RedBeard0531 deleted the ms/naa-upgrade branch April 5, 2023 14:29
@github-actions github-actions Bot locked as resolved and limited conversation to collaborators Mar 15, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Fix building for "Windows ia32" on main Possible breaking change in node-addon-api 5.1.0

2 participants