Skip to content

Codex CLI materials.#746

Open
rodrigogiraoserrao wants to merge 1 commit intomasterfrom
codex-cli
Open

Codex CLI materials.#746
rodrigogiraoserrao wants to merge 1 commit intomasterfrom
codex-cli

Conversation

@rodrigogiraoserrao
Copy link
Contributor

Where to put new files:

  • New files should go into a top-level subfolder, named after the article slug. For example: my-awesome-article

How to merge your changes:

  1. Make sure the CI code style tests all pass (+ run the automatic code formatter if necessary).
  2. Find an RP Team member on Slack and ask them to review & approve your PR.
  3. Once the PR has one positive ("approved") review, GitHub lets you merge the PR.
  4. 🎉

Copy link
Contributor

@acsany acsany left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @rodrigogiraoserrao!
Since I have only a few minor notes, I leave them here:

  1. Broken markdown link in top-level README (codex-cli/README.md line 3): There's a stray " breaking the link
  2. Project README prompt prefix (codex-cli/rpcontacts/README.md): Shows (venv) $ uv run rpcontacts. Do we need the (venv) prefix here or does uv take care of the venv?
  3. requires-python = ">=3.14": The code doesn't use any Python 3.14-specific features. Since uv handles Python installation automatically this isn't a hard blocker, but lowering to >=3.12 or >=3.13 would make the project accessible to more readers without uv

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants