Open
Conversation
acsany
requested changes
Mar 11, 2026
Contributor
acsany
left a comment
There was a problem hiding this comment.
Hi @rodrigogiraoserrao!
Since I have only a few minor notes, I leave them here:
- Broken markdown link in top-level README (
codex-cli/README.mdline 3): There's a stray"breaking the link - Project README prompt prefix (
codex-cli/rpcontacts/README.md): Shows(venv) $ uv run rpcontacts. Do we need the(venv)prefix here or does uv take care of the venv? requires-python = ">=3.14": The code doesn't use any Python 3.14-specific features. Since uv handles Python installation automatically this isn't a hard blocker, but lowering to>=3.12or>=3.13would make the project accessible to more readers without uv
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Where to put new files:
my-awesome-articleHow to merge your changes: