perf: use hash map for installed packages#7878
Open
calebdw wants to merge 1 commit intorectorphp:mainfrom
Open
perf: use hash map for installed packages#7878calebdw wants to merge 1 commit intorectorphp:mainfrom
calebdw wants to merge 1 commit intorectorphp:mainfrom
Conversation
calebdw
force-pushed
the
calebdw/push-vwytuonwkypl
branch
from
f924011 to
19ec4b8
Compare
calebdw
force-pushed
the
calebdw/push-vwytuonwkypl
branch
from
19ec4b8 to
4d4a674
Compare
Contributor
Author
|
@TomasVotruba, thoughts on this? The only error is because |
Member
|
I'll look into this. Can you remove the unused method? |
We can turn a package lookup into O(1) by using a hash map instead of an O(n) with a linear array.
calebdw
force-pushed
the
calebdw/push-vwytuonwkypl
branch
from
4d4a674 to
8f94788
Compare
Contributor
Author
|
@TomasVotruba, fixed! I added |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hello!
We can turn a package lookup into O(1) by using a hash map instead of an O(n) with a linear array.
Thanks!