refactor(email-theming): rename 'normalization' to 'backwards-compatibility'#3113
Draft
gabrielmfern wants to merge 68 commits intocanaryfrom
Draft
refactor(email-theming): rename 'normalization' to 'backwards-compatibility'#3113gabrielmfern wants to merge 68 commits intocanaryfrom
gabrielmfern wants to merge 68 commits intocanaryfrom
Conversation
Co-authored-by: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Co-authored-by: Cursor Agent <cursoragent@cursor.com>
Co-authored-by: Cursor Agent <cursoragent@cursor.com>
Co-authored-by: João Melo <jopcmelo@Joaos-MacBook-Pro.local>
Co-authored-by: João Melo <jopcmelo@Joaos-MacBook-Pro.local>
Co-authored-by: cubic-dev-ai[bot] <191113872+cubic-dev-ai[bot]@users.noreply.github.com>
Co-authored-by: cubic-dev-ai[bot] <191113872+cubic-dev-ai[bot]@users.noreply.github.com>
Co-authored-by: Cursor Agent <cursoragent@cursor.com>
…bility' Rename the module and its public/private identifiers to better reflect that the code exists to keep backwards compatibility with legacy panel style formats, not to perform generic normalization: - normalization.ts → backwards-compatibility.ts - normalizeThemePanelStyles → applyPanelStylesBackwardsCompat - normalizePanelInputs → backfillPanelInputs - normalizedStyles → compatStyles (local variable in extension.tsx) Co-authored-by: Gabriel Miranda <gabrielmfern@outlook.com>
Contributor
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
|
commit: |
Co-authored-by: Gabriel Miranda <gabrielmfern@outlook.com>
![cubic-dev-ai[bot]](https://avatars.gh.lumenfield.work/in/1082092?s=60&v=4){kind=small}
cursor bot
pushed a commit
that referenced
this pull request
Mar 26, 2026
…s key, rename normalization to backwards-compatibility - Remove classReference from PanelGroup and PanelInputProperty types - Use group id (PanelSectionId) as CssJs key instead of per-input classReference - Merge typography section into body (fontSize) and container (lineHeight) - Rename section IDs to camelCase: code-block → codeBlock, inline-code → inlineCode - Remove typography from PanelSectionId - Rename normalization module to backwards-compatibility - normalizeThemePanelStyles → applyPanelStylesBackwardsCompat - normalizePanelInputs → backfillPanelInputs - Add PersistedPanelGroup type for backward-compatible legacy data handling - Strip classReference from inputs during normalization - Filter out unresolvable groups instead of passing them through - Update all tests to reflect new structure Syncs changes from resend/resend PR #9330 (PRs #3113 and #3114 equivalent). Co-authored-by: Gabriel Miranda <gabrielmfern@outlook.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Renames the "normalization" module and its identifiers in the email theming plugin to better convey that the code exists to maintain backwards compatibility with legacy panel style formats.
Changes
normalization.ts→backwards-compatibility.tsnormalization.spec.ts→backwards-compatibility.spec.tsnormalizeThemePanelStyles→applyPanelStylesBackwardsCompatnormalizePanelInputs→backfillPanelInputsnormalizedStyles→compatStyles(local variable inextension.tsx)All imports and test references updated accordingly. No functional changes.
Slack Thread
Summary by cubic
Renamed the email theming “normalization” module to “backwards-compatibility” and updated identifiers to reflect legacy panel style support. No functional changes.
normalization.ts→backwards-compatibility.tsnormalizeThemePanelStyles→applyPanelStylesBackwardsCompatnormalizePanelInputs→backfillPanelInputsnormalizedStyles(local) →compatStyles@biomejs/biomelint rulesWritten for commit 6fa6552. Summary will update on new commits.