refactor: improve file:// URL loading in Android (PR #329 improvements)

[mfazekas]

Summary

Simplifies PR #329 by removing the unnecessary factory pattern and using a straightforward iOS-style approach with proper URI.scheme checking.

Changes

Removed:

• ResourceLoader interface
• VolleyHttpLoader class
• FileSystemLoader class
• ResourceLoaderFactory object

Added:

• Simple if/else using URI.scheme in downloadUrlAsset()
• loadFileUrlAsset() - Handles file:// URLs with background threading
• loadRemoteUrlAsset() - Wraps existing Volley HTTP logic

Key Improvements

1. Simpler architecture - Matches iOS pattern with simple conditional dispatch instead of factory pattern
2. Proper URI parsing - Uses java.net.URI and .scheme property instead of string.startsWith("file://")
3. Background threading - File I/O runs on Dispatchers.IO with callbacks on main thread
4. Better error handling - Checks file existence/permissions, returns 404 for FileNotFoundException

Code Comparison

Before (factory pattern):

val loader = ResourceLoaderFactory.getLoader(url, context)
loader.loadResource(url, listener, errorListener)

After (simple dispatch):

val uri = URI(url)
when (uri.scheme) {
  "file" -> loadFileUrlAsset(uri, listener)
  else -> loadRemoteUrlAsset(url, listener)
}

Result: 16 fewer lines, more maintainable, platform consistency with iOS.

Related

• Builds on PR Fix loading of file:// URLs in Android release #329 by @ckknight
• Follows iOS patterns from PR Fix file:// URLs on iOS so expo-asset works #344

🤖 Generated with Claude Code

Co-Authored-By: Claude noreply@anthropic.com