Deprecate elimtype and casetype tactics#16904
Merged
coqbot-app[bot] merged 4 commits intorocq-prover:masterfrom Jan 3, 2023
Merged
Deprecate elimtype and casetype tactics#16904coqbot-app[bot] merged 4 commits intorocq-prover:masterfrom
coqbot-app[bot] merged 4 commits intorocq-prover:masterfrom
Conversation
ppedrot
added
the
request: full CI
coqbot-app
Bot
removed
the
request: full CI
Contributor
|
The job library:ci-fiat_crypto_legacy has failed in allow failure mode |
Member
Author
|
A cursory look at the sources of the broken CI devs seem to indicate that all uses of |
ppedrot
added a commit
to ppedrot/bbv
that referenced
this pull request
Nov 25, 2022
This means turning some elimtype False into exfalso.
ppedrot
added a commit
to ppedrot/kami
that referenced
this pull request
Nov 25, 2022
ppedrot
added a commit
to ppedrot/coqprime
that referenced
this pull request
Nov 25, 2022
ppedrot
added a commit
to ppedrot/smtcoq
that referenced
this pull request
Nov 25, 2022
ppedrot
added a commit
to ppedrot/corn
that referenced
this pull request
Nov 25, 2022
ppedrot
added a commit
to ppedrot/jasmin
that referenced
this pull request
Nov 25, 2022
ppedrot
added a commit
to ppedrot/tlc
that referenced
this pull request
Nov 25, 2022
ppedrot
added a commit
to ppedrot/Coq-Equations
that referenced
this pull request
Nov 25, 2022
ppedrot
added a commit
to ppedrot/fiat
that referenced
this pull request
Nov 25, 2022
ppedrot
added a commit
to ppedrot/fiat
that referenced
this pull request
Nov 25, 2022
ppedrot
added a commit
to ppedrot/fiat
that referenced
this pull request
Nov 25, 2022
ppedrot
added a commit
to ppedrot/sf
that referenced
this pull request
Nov 25, 2022
eponier
pushed a commit
to jasmin-lang/jasmin
that referenced
this pull request
Nov 25, 2022
JasonGross
pushed a commit
to ppedrot/fiat
that referenced
this pull request
Nov 25, 2022
JasonGross
pushed a commit
to mit-plv/fiat
that referenced
this pull request
Nov 25, 2022
Member
|
The use of |
charguer
added a commit
to charguer/tlc
that referenced
this pull request
Nov 25, 2022
Adapt w.r.t. rocq-prover/rocq#16904 by removing references to "elimtype False".
samuelgruetter
added a commit
to mit-plv/bbv
that referenced
this pull request
Nov 25, 2022
samuelgruetter
added a commit
to mit-plv/kami
that referenced
this pull request
Nov 25, 2022
vbgl
pushed a commit
to jasmin-lang/jasmin
that referenced
this pull request
Nov 28, 2022
(cherry picked from commit de18c89)
ckeller
pushed a commit
to smtcoq/smtcoq
that referenced
this pull request
Nov 28, 2022
bcpierce00
added a commit
to DeepSpec/sf
that referenced
this pull request
Nov 28, 2022
Contributor
|
The job library:ci-fiat_crypto_legacy has failed in allow failure mode |
ppedrot
added a commit
to rocq-prover/equations
that referenced
this pull request
Dec 5, 2022
We take the opportunity to use the stdlib-registered empty type instead of the literal Coq.Logic.False type, so as to be more modular.
ppedrot
added
the
request: full CI
ppedrot
force-pushed
the
deprecate-elim-case-type
branch
from
f6f2638 to
dd25f5b
Compare
coqbot-app
Bot
removed
the
request: full CI
andres-erbsen
approved these changes
Dec 21, 2022
xavierleroy
pushed a commit
to AbsInt/CompCert
that referenced
this pull request
Dec 22, 2022
Adapt w.r.t. rocq-prover/rocq#16904.
Alizter
pushed a commit
to Alizter/flocq-fork
that referenced
this pull request
Dec 24, 2022
Alizter
pushed a commit
to Alizter/flocq-fork
that referenced
this pull request
Dec 24, 2022
Adapt w.r.t. rocq-prover/rocq#16904. See merge request flocq/flocq!20
Alizter
pushed a commit
to Alizter/flocq-fork
that referenced
this pull request
Dec 24, 2022
For some reason I only commited the elimtype removal in the MR, and didn't push the casetype removal.
Alizter
pushed a commit
to Alizter/flocq-fork
that referenced
this pull request
Dec 24, 2022
Adapt w.r.t. rocq-prover/rocq#16904 (again). See merge request flocq/flocq!21
And stop manually adding it in common.edit_mlg.
coqbot-app
Bot
added
the
needs: full CI
Member
|
I have pushed a commit fixing the issue I had reported in the doc, as well as |
SkySkimmer
approved these changes
Jan 3, 2023
SkySkimmer
removed
the
needs: full CI
Contributor
|
@coqbot merge now |
Member
There already is such a check, but it is only applied when you add the production to a nonterminal. It's not applied for editing operations such as |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
These are basically vestigial tactics that survived the V7-V8 geological crisis. They only survived in some rare instances in the stdlib, and I suspect that they're just not used in the CI. In order to test this the last commit of the PR removes them just to see what happens, as an experiment.
EDIT: all the instances of elimtype removed from the stdlib in this PR were already there in Coq V5, so we're really talking archaeology here.