-
Notifications
You must be signed in to change notification settings - Fork 81
Expect escaped backslashes in expressions to inspect #68
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from 3 commits
Commits
Show all changes
6 commits
Select commit
Hold shift + click to select a range
6d58999
Expect escaped backslashes in expressions to inspect
valich 3d07d6b
version up
valich 62f44c6
unit-testing of incoming unescaping, fixed inspect test
valich b59de9a
fix chain call for ruby 1.8
valich 5c4cb62
Fix expression_info command failing with new unescaping;
valich 314460a
Don't def encoding method for StringIO if ruby 1.8
valich File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,3 +1,3 @@ | ||
| module Debugger | ||
| IDE_VERSION='0.4.27' | ||
| IDE_VERSION='0.4.28' | ||
| end |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,34 @@ | ||
| require 'test/unit' | ||
| require 'ruby-debug-ide/command' | ||
|
|
||
| class UnescaperTest < Test::Unit::TestCase | ||
|
|
||
| def test_empty | ||
| do_test('', '') | ||
| do_test('a', 'a') | ||
| end | ||
|
|
||
| def test_newline | ||
| do_test('\n', "\n") | ||
| do_test('a\n', "a\n") | ||
| end | ||
|
|
||
| def test_escaped_newline | ||
| do_test('\\\\n', '\n') | ||
| do_test('a\\\\n', 'a\n') | ||
| end | ||
|
|
||
| def test_backslash_and_newline | ||
| do_test('\\\\\\n', "\\\n") | ||
| do_test('a\\\\\\n', "a\\\n") | ||
| end | ||
|
|
||
| def test_something | ||
| do_test('hello\nthere\\\\n', "hello\nthere\\n") | ||
| do_test('"\\\\\\n".size', "\"\\\n\".size") | ||
| end | ||
|
|
||
| def do_test(input, expected_result) | ||
| assert_equal(expected_result, Debugger::Command.unescape_incoming(input)) | ||
| end | ||
| end |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not sure this type of continuation is allowed in 1.8
Please double-check.