Merged
Conversation
Member
|
Thanks for the PR, could you add tests for this? |
…r and added tests
…r and added tests
Cosmicoppai
commented
Oct 14, 2024
Member
|
Could you also update the docs? |
jeremyevans
requested changes
Nov 18, 2024
Contributor
jeremyevans
left a comment
There was a problem hiding this comment.
Thank you for working on this. I agree we should raise for negative numbers, as you can make the argument that the timeout has already expired. It's arguable whether we should raise Timeout::Error (or klass) in this case, instead of ArgumentError, but I'm not opposed to using ArgumentError. I do have a couple inline requests for changes.
Co-authored-by: Jeremy Evans <code@jeremyevans.net>
Co-authored-by: Jeremy Evans <code@jeremyevans.net>
jeremyevans
approved these changes
Nov 21, 2024
Contributor
|
Sorry I missed approving this a few days ago. Thanks for the reminder! |
Contributor
Author
|
@eregon whenever you find time, I’d greatly appreciate your review on the updated changes, thank you for your guidance! |
Member
|
LGTM, thanks for the review @jeremyevans |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Potential issues with current behaviour:
I suggest this change for the consistent behaviour regardless of code-block as well as the clear indication of the source of the error