chore: Rename Component::name_in_manifest and short_name_in_manifest method to name and short_name#4778
Merged
rami3l merged 2 commits intorust-lang:mainfrom Mar 28, 2026
Merged
Conversation
Cloud0310
changed the title
Component::name_in_manifest and short_name_in_manifest method to name and short_nameComponent::name_in_manifest and short_name_in_manifest method to name and short_name
djc
approved these changes
Mar 26, 2026
rami3l
approved these changes
Mar 26, 2026
Contributor
Author
|
Added new comments for clarify the usage of the functions in latest commit here. |
This comment has been minimized.
This comment has been minimized.
Cloud0310
force-pushed
the
rename-method
branch
from
0315fef to
432d155
Compare
This comment has been minimized.
This comment has been minimized.
…t_name` accordingly In `Component`, these methods are not related to the final name associated with manifest. On the `Manifest` side, it have `name` and `short_name` for get the re-mapped component names. So, I think renaming these func names in Component helps clarify the the code.
Cloud0310
force-pushed
the
rename-method
branch
from
432d155 to
c2e1cc7
Compare
Collaborator
|
This PR was rebased onto a different main commit. Here's a range-diff highlighting what actually changed. Rebasing is a normal part of keeping PRs up to date, so no action is needed—this note is just to help reviewers. |
Cloud0310
force-pushed
the
rename-method
branch
2 times, most recently
from
b1a9a64 to
d9c345d
Compare
rami3l
approved these changes
Mar 28, 2026
rami3l
reviewed
Mar 28, 2026
`Manifest::name` and the `short_name` funcc accordingly.
Cloud0310
force-pushed
the
rename-method
branch
from
d9c345d to
ec81749
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
These function on
Componentis not related toManifest, so renaming them to distinguish againstManifest::name()andManifest::short_name().Founded this problem when I was dealing with #4768. By naming, two functions looks like should be the same, but they're actually different things.
ref: src/dist/manifest.rs#L55-L62 src/dist/manifest.rs#L55-L62