Organization-only mode leaks the grain name

[robinp]

Even if "Disallow collaboration with users outside the organization" is turned on, visiting the shared link from a private window would display the grain title.

[ocdtrekkie]

My first pass inclination would be that this is probably not a significant issue, in the light that a share link is a secret which grants access to the resource. In capability security models, having it is permission to use it. So the security problem is that someone got a share link, not that having it tells you the name of the grain.

The "disallow collaboration" option is chiefly just to stop people from being able to register accounts. Though it does state that it blocks the ability to "view grains" even with a sharing link here: https://docs.sandstorm.io/en/latest/administering/for-work/

[robinp]

I agree it is not a significant issue, but would like to shade with two points:

1. Given Sandstorm strong security-conscious perspective (as suggested by documentation and landing material), it sounds like a too low-hanging fruit to leave open?

2. The naive user when reading the checkbox description under the Admin panel

Disallow collaboration with users outside the organization.
Users will be required to log in as a member of your organization to view sharing links. Guest access will be disabled.

says "to view sharing links" and "guest access will be disabled". Maybe this is a wording problem and this should get softened to something like "guests will still be able to see minimal information about the grain like title and (???) before getting denied", but in current form, raises false expectations.

That said, I understand everything is subject to risks/priorities, and with a bit of wording change this indeed would be very low risk.