This repository was archived by the owner on Nov 27, 2022. It is now read-only.
Conversation
Android seems to be using nanosecond whereas iOS uses milliseconds. This makes velocity values way lower on Android. facebook/react-native@f2c1868
|
|
||
| const POSITION_THRESHOLD = 120; | ||
| const VELOCITY_THRESHOLD = 0.000001; | ||
| const VELOCITY_THRESHOLD = Platform.OS === 'android' ? 0.0000005 : 0.5; // on Android, velocity is way lower, perhaps due to timestamp being in nanosecond |
Owner
Author
There was a problem hiding this comment.
There's a open PR which fixes this, we can remove this condition when it goes to stable - facebook/react-native#8199
jzhan-canva
pushed a commit
to jzhan-canva/react-native-tab-view
that referenced
this pull request
Jun 21, 2018
Dynamic width tabs
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
cc @jsierles