Refactor Field class to accept type_ in constructor#9
Refactor Field class to accept type_ in constructor#9shaonianche wants to merge 3 commits intomainfrom
Conversation
This change moves the assignment of the `type_` attribute into the `Field` class constructor, eliminating the need for external assignment in `fit_tool/gen/profile.py`. This addresses the technical debt identified by a TODO comment. Changes: - Modified `fit_tool/field.py`: Added `field_type` parameter to `__init__` and assigned it to `self.type_`. Updated `from_field` to propagate the attribute. - Modified `fit_tool/gen/profile.py`: Passed `field_type` during `Field` instantiation and removed the manual assignment. Co-authored-by: shaonianche <16186646+shaonianche@users.noreply.github.com>
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
Summary of ChangesHello @shaonianche, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request refactors the Highlights
🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console. Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
![gemini-code-assist[bot]](https://avatars.gh.lumenfield.work/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request refactors the Field class to accept the type_ attribute in its constructor, which is a good cleanup of technical debt. The changes are implemented correctly. I've added a few suggestions to improve the naming consistency of the new parameter for better readability and maintainability.
fit_tool/field.py
Outdated
| self.ref_field_map = ref_field_map | ||
| self.array_type = array_type | ||
| self.array_fixed_length = array_fixed_length | ||
| self.type_ = field_type |
There was a problem hiding this comment.
If the constructor parameter is renamed to type_ for consistency, this line should be updated accordingly.
| self.type_ = field_type | |
| self.type_ = type_ |
fit_tool/gen/profile.py
Outdated
| array_type=array_type, | ||
| array_fixed_length=array_fixed_length | ||
| array_fixed_length=array_fixed_length, | ||
| field_type=type_ |
There was a problem hiding this comment.
If the Field constructor parameter is renamed from field_type to type_, this call site should be updated.
| field_type=type_ | |
| type_=type_ |
This change moves the assignment of the `type_` attribute into the `Field` class constructor, eliminating the need for external assignment in `fit_tool/gen/profile.py`. This addresses the technical debt identified by a TODO comment. Changes: - Modified `fit_tool/field.py`: Added `type_` parameter to `__init__` and assigned it to `self.type_`. Updated `from_field` to propagate the attribute. - Modified `fit_tool/gen/profile.py`: Passed `type_` during `Field` instantiation and removed the manual assignment. Co-authored-by: shaonianche <16186646+shaonianche@users.noreply.github.com>
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #9 +/- ##
=======================================
Coverage ? 89.03%
=======================================
Files ? 20
Lines ? 1359
Branches ? 0
=======================================
Hits ? 1210
Misses ? 149
Partials ? 0 ☔ View full report in Codecov by Sentry. |
This change moves the assignment of the `type_` attribute into the `Field` class constructor, eliminating the need for external assignment in `fit_tool/gen/profile.py`. This addresses the technical debt identified by a TODO comment. Changes: - Modified `fit_tool/field.py`: Added `type_` parameter to `__init__` (defaulting to None) and assigned it to `self.type_`. Updated `from_field` to propagate the attribute. - Modified `fit_tool/gen/profile.py`: Passed `type_` during `Field` instantiation and removed the manual assignment. Co-authored-by: shaonianche <16186646+shaonianche@users.noreply.github.com>
fix(ci.yml): update Python version matrix to include 3.14
shaonianche
deleted the
refactor-field-type-assignment-16951162587970221993
branch
1 participant
Moved
type_assignment toFieldconstructor to cleanup technical debt.PR created automatically by Jules for task 16951162587970221993 started by @shaonianche