Make .delete() return a boolean#66
Merged
sindresorhus merged 10 commits intosindresorhus:masterfrom Sep 6, 2020
Merged
Conversation
Signed-off-by: Richie Bendall <richiebendall@gmail.com>
Owner
|
I misunderstood your request. I thought you mean to return whether it was deleted or not. I think that makes more sense. Like https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Objects/Set/delete |
Signed-off-by: Richie Bendall <richiebendall@gmail.com>
Richienb
changed the title
.delete().delete()
Contributor
Author
|
@sindresorhus I've changed the logic to implement that. Travis CI is not working right now. |
sindresorhus
reviewed
Sep 5, 2020
sindresorhus
reviewed
Sep 5, 2020
Co-authored-by: Sindre Sorhus <sindresorhus@gmail.com>
sindresorhus
changed the title
.delete().delete() return a boolean
This was referenced Mar 11, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes: #65
// @sindresorhus