fix: add missing lazy parameter to listener method type hints#1469
Open
quicksilversel wants to merge 2 commits intoslackapi:mainfrom
Open
fix: add missing lazy parameter to listener method type hints#1469quicksilversel wants to merge 2 commits intoslackapi:mainfrom
quicksilversel wants to merge 2 commits intoslackapi:mainfrom
Conversation
Adds the `lazy` parameter to the type signatures of all 18 listener registration methods in both `App` and `AsyncApp`. The parameter was already handled at runtime via **kwargs but was missing from the method signatures, causing mypy errors when users passed lazy=[...]. No runtime behavior changes. Fixes slackapi#1412
|
Thanks for the contribution! Before we can merge this, we need @quicksilversel to sign the Salesforce Inc. Contributor License Agreement. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
lazyparameter to the type signatures of all 18 listener registration methods (event,message,command,action,shortcut,view,options,function, and their variants) in bothAppandAsyncApp**kwargsin the inner__call__functions; this fix surfaces it in the type signatures for mypy and IDE autocompletionFixes #1412
Category
slack_bolt.Appand its core componentsslack_bolt.AsyncAppand its core componentsslack_bolt.adapterTest plan
./scripts/format.shpasses./scripts/lint.shpasses./scripts/run_mypy.shpasses./scripts/run_tests.sh tests/scenario_tests/test_app.pypasses