Skip to content

chore: cleanup package-lock.json#1571

Merged
WilliamBergamin merged 1 commit intomainfrom
remove-package-lock
Mar 26, 2026
Merged

chore: cleanup package-lock.json#1571
WilliamBergamin merged 1 commit intomainfrom
remove-package-lock

Conversation

@WilliamBergamin
Copy link
Copy Markdown
Contributor

This PR removed the package-lock.json since it seems to have been added accidentally

Category

  • bolt (Bolt for Java)
  • bolt-{sub modules} (Bolt for Java - optional modules)
  • slack-api-client (Slack API Clients)
  • slack-api-model (Slack API Data Models)
  • slack-api-*-kotlin-extension (Kotlin Extensions for Slack API Clients)
  • slack-app-backend (The primitive layer of Bolt for Java)

Requirements

Please read the Contributing guidelines and Code of Conduct before creating this issue or pull request. By submitting, you agree to those rules.

@WilliamBergamin WilliamBergamin added this to the 1.48.1 milestone Mar 26, 2026
@WilliamBergamin WilliamBergamin self-assigned this Mar 26, 2026
@WilliamBergamin WilliamBergamin requested a review from a team as a code owner March 26, 2026 14:59
@codecov
Copy link
Copy Markdown

codecov bot commented Mar 26, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 73.34%. Comparing base (b8152df) to head (b32be59).
⚠️ Report is 1 commits behind head on main.
✅ All tests successful. No failed tests found.

Additional details and impacted files
@@            Coverage Diff            @@
##               main    #1571   +/-   ##
=========================================
  Coverage     73.33%   73.34%           
- Complexity     4520     4521    +1     
=========================================
  Files           477      477           
  Lines         14283    14283           
  Branches       1487     1487           
=========================================
+ Hits          10475    10476    +1     
+ Misses         2924     2923    -1     
  Partials        884      884           
Flag Coverage Δ
jdk-14 73.34% <ø> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Copy Markdown
Member

@zimeg zimeg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@WilliamBergamin LGTM! IIRC this might've been used with earlier docs builds but I agree it's a good time to remove the lockfile 🔏 🪓

@zimeg zimeg added dependencies Pull requests that update a dependency file javascript Pull requests that update Javascript code labels Mar 26, 2026
@WilliamBergamin WilliamBergamin merged commit f1280c4 into main Mar 26, 2026
7 checks passed
@WilliamBergamin WilliamBergamin deleted the remove-package-lock branch March 26, 2026 18:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

dependencies Pull requests that update a dependency file javascript Pull requests that update Javascript code

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants