code opt: performance optimization#899
Merged
smallnest merged 3 commits intosmallnest:masterfrom Apr 26, 2025
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
1.file: client.go function: urlencode
a Builder is used to efficiently build a string using Write methods. it minimizes memory copying. Builder directly converts the underlying []byte to a string type and returns it.
BenchmarkURLEncodeBuilder-8 5000000 220 ns/op 64 B/op 2 allocs/op
BenchmarkURLEncodeBuffer-8 4000000 280 ns/op 80 B/op 3 allocs/op
2.file: client.go function: urlencode
reduce memory allocation: avoid the redundant operation of extracting the last "&" at the end.
3.file: server_reflection.go function1:String function2:GetServices
replace bytes.Buffer with strings.Builder.