Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
|
👋 huangzhen1997, thanks for creating this pull request! To help reviewers, please consider creating future PRs as drafts first. This allows you to self-review and make any final changes before notifying the team. Once you're ready, you can mark it as "Ready for review" to request feedback. Thanks! |
Coverage Report |
andrevmatos
left a comment
There was a problem hiding this comment.
Some simplifications, but mostly lgtm
krebernisak
left a comment
There was a problem hiding this comment.
LGTM - I second feedback from Andre, and would be great to add SUI in the same PR
| .storeUint(tokenReceiver, 256) // uint256 | ||
| .storeRef(accountsCell) // SnakedCell<uint256> | ||
|
|
||
| return builder.endCell() |
There was a problem hiding this comment.
Can we please test TONChain.encodeExtraArgs() with these, and decodeExtraArgs its result?
The encode method isn't actively used right now, as we build the cells directly here from the ExtraArgs object when we need to ccipSend below, so we use the Cell result directly, which should be fine.
But in ccip-o11y, we'll need to serialize those to store in ccip-o11y-db, and it'd be good to have a consistent way to serialize them here (we may eventually pull ccip-sdk into ccip-o11y, and then we'll need this). Also, the serialized extraArgs coming from ccip-o11y db through CCIP-API for these will be decoded.
So far for EVM, our idea was to store only the bits content of the cell in serialized form (i.e. NOT the whole serialized cell), so it can begin with the tag, for consistency with all other chain families. But we need to make sure this also works for these snaked cells.
Adds SVMExtraArgsV1 encoding support for TON source chain, enabling TON → Solana CCIP messages.