add typescript classes created with script for review#13
Conversation
| this.overwrite("http://rdfs.org/sioc/ns#content", value, TermMapping.stringToLiteral); | ||
| } | ||
| get relatedChatChannel(): Set<string> { | ||
| return this.objects("n3-52", ValueMapping.literalToString, TermMapping.stringToLiteral); |
There was a problem hiding this comment.
The string used as predicate looks like a blank node label. I'm sure this is unintentional. It would not work.
It probably highlights some fundamental parser/generator problem in the converter.
There was a problem hiding this comment.
unresolved - the SHACL shape property from SolidOS uses [ sh:path [ sh:inversePath flow:message ]
[ sh:path [ sh:inversePath flow:message ] ;
sh:minCount 1 ;
rdfs:label "Related Chat" ;
rdfs:comment "The chat channel or conversation to which this message belongs." ;
sh:codeIdentifier "relatedChatChannel";
]
There was a problem hiding this comment.
the SHACL shape property from SolidOS uses
[ sh:path [ sh:inversePath flow:message ]
I highly recommend that we don't try to support this pattern in the converter.
I can imagine some interpretations that would make sense in the context of generating classes/properties from these shapes.
But I still think that restricting these shapes to using only 'simple' sh:paths with IRI objects is the correct current approach.
|
https://github.com/solid/object/blob/main/src/solid/Container.ts compare with |
|
Hi @langsamu @matthieubosquet - there is a of blocker for the solid/shapes and shapes transform work, that @jeswr would like to have resolved today. Wonder if you're able to take a look and advise on this please: With the current version of Container.ts, why is Container extending Resource rather than TermWrapper? |
Because a In my opinion, the SHACL translator should support this feature. However there is nothing in my mind that requires modelling any particular mapping class as extending any other. |
Branch created with Typescript classes created from SHACL shapes in https://github.com/solid/shapes using https://github.com/theodi/shacl-shape-converter-typescript