Merged
Conversation
Contributor
Author
|
Should I rename it to Line 518 in fedab8d |
Collaborator
No reason to. Tensors in tract are always in "natural order" (row major, but generalized, axes with bigger strides come first). |
Contributor
Author
|
Hi~ Shall we rerun CI? |
Collaborator
Sure, let's see where we are. :) But we need to address the ndarray-npy situation before moving further (as in merge). |
7673875 to
cef2286
Compare
Contributor
Author
|
@kali Let's rerun CI. Thanks |
cef2286 to
c0a6103
Compare
Collaborator
|
thanks for your contibution! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Blocked by jturner314/ndarray-npy#73