On Darwin, ignore anything but system's ranlib. Fixes #1812#1813
On Darwin, ignore anything but system's ranlib. Fixes #1812#1813flavorjones merged 1 commit intosparklemotion:masterfrom gpakosz:darwin-ranlib
Conversation
|
This is related to #1812 |
|
/cc @zenspider Can you please take a look at this. |
|
@zenspider @flavorjones I hit this many times for each my environments... |
|
@nurse Can you confirm that this fix addresses your issue? I have no easy way to test. |
|
@nurse Now I'm curious. Do you have GNU's |
|
@flavorjones It also needs @gpakosz I want to have |
|
Will take a look in the morning. The failing tests in CI are unrelated. |
|
Merged into master. |
|
Thank you for releasing 1.9.0.rc1 and I successfully installed it! |
This PR makes it so the call to
libxml2'sconfigurescript is done with passingRANLIB=/usr/bin/ranlibwhen running on Darwin.This makes building native extensions more robust to the target system in the following situation:
PATH/usr/local/binIn particular, having
libxml2build call GNU'sranlibinstead of Darwin'sranlibfails building native extensions with very cryptic error messages. The root cause is far from being obvious and one can waste many hours on it.As such, I suggest trying to spare users and maintainers' time (less issues opened) by helping
libxml2's build system a bit.