Update Windows cross build for ruby-2.6#1850
Merged
flavorjones merged 1 commit intosparklemotion:masterfrom Dec 28, 2018
Merged
Update Windows cross build for ruby-2.6#1850flavorjones merged 1 commit intosparklemotion:masterfrom
flavorjones merged 1 commit intosparklemotion:masterfrom
Conversation
Add a JRuby task which makes use of new JRuby support in rake-compiler-dock-0.7.0
Member
|
@larskanis Thank you! Will merge in the morning and planning to cut v1.10.0 this week. |
flavorjones
added a commit
that referenced
this pull request
Dec 28, 2018
Member
|
... And I've updated |
Member
|
@larskanis I've just cut v1.10.0.rc1, could you please make sure the windows gems look OK to you? |
Member
Author
|
@flavorjones Looks good to me. I tested v1.10.0.rc1 on Windows server 2016:
Everthing succeeded.
|
Member
|
Awesome, thank you for performing those tests! Yes, the compilation warnings have been around for a while and aren't new with 2.6. I've tried squashing them but couldn't find a way to do it without introducing |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This also adds a JRuby task which makes use of new JRuby support in rake-compiler-dock-0.7.0. I'm not sure whether this is something for build_all.
Fixes #1842 .