fix(jruby): XML::DocumentFragment.dup to another document#3372
Merged
flavorjones merged 1 commit intomainfrom Dec 12, 2024
Merged
fix(jruby): XML::DocumentFragment.dup to another document#3372flavorjones merged 1 commit intomainfrom
flavorjones merged 1 commit intomainfrom
Conversation
Back in b92660e (#1834 fixing #1063) I omitted support in JRuby for the "new_parent_document" argument to `Node#dup` because there was no performance reason to implement it. So the test was skipped. However, in 1e7d38a and other commits in #3117 (fixing #316), I introduced a call to `initialize_copy_with_args` that passes the new parent document as an argument on both CRuby and JRuby implementations. Because the test was skipped, I didn't catch that this broke on JRuby. In particular this was a problem for Loofah which relies on decorators, and even more particularly this broke the `Loofah::TextBehavior` formatting concern for `Loofah::*::DocumentFragment` objects. Maybe we should be running downstream tests with JRuby, too? But that feels like a big investment right now so I'll avoid scarring on the first cut, and wait to see if it happens again.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What problem is this PR intended to solve?
Back in b92660e (#1834 fixing #1063) I omitted support in JRuby for the "new_parent_document" argument to
Node#dupbecause there was no performance reason to implement it. So the test was skipped.However, in 1e7d38a and other commits in #3117 (fixing #316), I introduced a call to
initialize_copy_with_argsthat passes the new parent document as an argument on both CRuby and JRuby implementations. Because the test was skipped, I didn't catch that this broke on JRuby.In particular this was a problem for Loofah which relies on decorators, and even more particularly this broke the
Loofah::TextBehaviorformatting concern forLoofah::*::DocumentFragmentobjects.Have you included adequate test coverage?
The skipped test is no longer skipped!
Maybe we should be running downstream tests with JRuby, too? But that feels like a big investment right now so I'll avoid scarring on the first cut, and wait to see if it happens again.
Does this change affect the behavior of either the C or the Java implementations?
Brings the Java impl into agreement with the C impl.