Inconsistent out of bounds errors

[sagikazarmark]

The library currently handles out of bounds errors inconsistently:

• Strings exceeding int64 and uint64 bounds will return an error (from strconv)
• Strings exceeding other int/uint types won't return an error (unless it overflows int64/uint64) (no bit size in strconv)
• Any other number conversions will silently overflow (which is how Go handles casting internally)

At least string parsing should be consistent.

Also see #171

[ccoVeille]

You listed the reason why I created my lib 😅

https://github.com/ccoVeille/go-safecast

But I did before I discovered this repository that is widely used by everyone, but was facing the issues you listed.

[sagikazarmark]

The reason why I'm unsure about the right solution is because go actually allows overflow while casting from one type to the other:

https://go.dev/play/p/CJIDZl0aCla

But when parsing from string, that's not exactly how it works (at least for the upper bound of each type).

Not to mention that for unsigned types, we return an error at the moment. 🙈

So the options are:

• do not allow overflow at all
• do not allow overflow when parsing from string
• leave everything as is and create a safecast package that enforces type boundaries

[ccoVeille]

The reason why I'm unsure about the right solution is because go actually allows overflow while casting from one type to the other:

https://go.dev/play/p/CJIDZl0aCla

But when parsing from string, that's not exactly how it works (at least for the upper bound of each type).

Not to mention that for unsigned types, we return an error at the moment. 🙈

So the options are:

• do not allow overflow at all
• do not allow overflow when parsing from string
• leave everything as is and create a safecast package that enforces type boundaries

I know I went through all this by working on my lib, as I told you here.

#260 (comment)

• leave everything as is and create a safecast package that enforces type boundaries

Don't you want to use mine? PRs are welcomed 😅😁