Skip to content

Remove pkg_resources#3371

Merged
dlstadther merged 4 commits intospotify:masterfrom
nileracecrew:master
Feb 8, 2026
Merged

Remove pkg_resources#3371
dlstadther merged 4 commits intospotify:masterfrom
nileracecrew:master

Conversation

@nileracecrew
Copy link
Contributor

Taking a shot at #3351. I brought it up to latest master to see if it's still failing CI. The CI logs for #3351 are no longer available, so I wanted to re-run CI to see what's going on.

@nileracecrew nileracecrew requested review from a team and dlstadther as code owners January 14, 2026 02:59
Copy link
Collaborator

@dlstadther dlstadther left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If i'm not mistaken, this is the exact place where the previous PR attempt started and where I asked for test coverage where possible to confirm behavior and address the codecov failures.

Can you look into testing options?

@nileracecrew
Copy link
Contributor Author

nileracecrew commented Jan 22, 2026

Hi @dlstadther,

It looks like there's a slight difference in that all existing unit tests are now passing (previously it seems that there were some possibly spurious failures).

Currently the test coverage change is net zero; the only failure is that this file falls below targets.

I did look a bit into adding a new test. It looks like there is insufficient mocking of the sch object, but I'm not sure how deep it needs to go. FWIW all the existing tests in this class are marked skipOnTravisAndGithubActions anyway: test/server_test.py#L327

@dlstadther
Copy link
Collaborator

Luigi's codecov stuff has always been a pain. I'll take a look at it over the coming days and see what changes I can make to it to try reducing issues it causes without getting too relaxed with test coverage expectations.

Copy link
Collaborator

@dlstadther dlstadther left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry for the delay, but i pulled the codecov strictness back and now this PR is passing.

@dlstadther dlstadther merged commit fc62c36 into spotify:master Feb 8, 2026
50 checks passed
@dlstadther dlstadther mentioned this pull request Feb 8, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants