feat: Add generic database connection mechanism by sbernauer · Pull Request #1163 · stackabletech/operator-rs

sbernauer · 2026-03-02T10:21:05Z

Description

Part of stackabletech/issues#238

Definition of Done Checklist

Not all of these items are applicable to all PRs, the author should update this template to only leave the boxes in that are relevant
Please make sure all these things are done and tick the boxes

Author

Changes are OpenShift compatible
CRD changes approved
CRD documentation for all fields, following the style guide.
Integration tests passed (for non trivial changes)
Changes need to be "offline" compatible

Reviewer

Code contains useful comments
Code contains useful logging statements
(Integration-)Test cases added
Documentation added or updated. Follows the style guide.
Changelog updated
Cargo.toml only contains references to git tags (not specific commits or branches)

Acceptance

Feature Tracker has been updated
Proper release label has been added

This reverts commit 8e05224. It was actually mot needed :)

crates/stackable-operator/src/database_connections/drivers/celery.rs

crates/stackable-operator/src/databases/drivers/jdbc.rs

Techassi

Only a partial review, but I left a bunch of comments with my concern and ideas/suggestions

crates/stackable-operator/src/builder/pod/container.rs

crates/stackable-operator/src/builder/pod/env.rs

crates/stackable-operator/src/databases/databases/mysql.rs

crates/stackable-operator/src/database_connections/databases/mysql.rs

crates/stackable-operator/src/databases/databases/derby.rs

crates/stackable-operator/src/database_connections/drivers/jdbc.rs

crates/stackable-operator/src/databases/helpers.rs

crates/stackable-operator/src/database_connections/mod.rs

crates/xtask/src/crd/dummy.rs

crates/stackable-operator/src/databases/drivers/jdbc.rs

crates/stackable-operator/src/databases/drivers/sqlalchemy.rs

crates/stackable-operator/src/database_connections/databases/postgresql.rs

crates/stackable-operator/src/databases/databases/postgresql.rs

crates/stackable-operator/src/databases/drivers/celery.rs

crates/stackable-operator/src/databases/drivers/jdbc.rs

crates/stackable-operator/src/databases/drivers/sqlalchemy.rs

Co-authored-by: Malte Sander <malte.sander.it@gmail.com>

Co-authored-by: Techassi <git@techassi.dev>

…tion<String>

sbernauer added 13 commits February 11, 2026 15:41

WIP

df6084b

postgres -> postgresql

f8a0b62

Store username and password envs separately

1dc73a1

Better name modules

c581a5b

Remove leftover code

32c0ec9

Switch to config-utils templating

b9a16a9

Add TODO marker

b51f227

Add MySQL

159faac

Improve Derby JDBC driver

9bb1e95

empty commit

c2799fa

Auto-create Derby database

69fbb2a

Merge remote-tracking branch 'origin/main' into spike/generic-databases

675dcc8

Update module structure

f457c20

sbernauer mentioned this pull request Mar 2, 2026

Implement generic database connection stackabletech/hive-operator#677

Open

sbernauer added 7 commits March 2, 2026 12:52

clippy

7c193c4

cargo fmt

9e31680

Implement CeleryConnection for Postgresql

33ae519

Support specifying the templating mechanism

cfa085d

fix: Use $VAR instead of ${VAR} (for Airflow)

8e05224

Revert "fix: Use $VAR instead of ${VAR} (for Airflow)"

49f8ba0

This reverts commit 8e05224. It was actually mot needed :)

Add lots of docs

3e391ff

sbernauer mentioned this pull request Mar 4, 2026

tracking: Generic Database connection rollout stackabletech/issues#238

Open

19 tasks

Merge branch 'main' into spike/generic-databases

a21b8bd

sbernauer marked this pull request as ready for review March 4, 2026 14:23

sbernauer commented Mar 4, 2026

View reviewed changes

crates/stackable-operator/src/database_connections/drivers/celery.rs Outdated Show resolved Hide resolved

sbernauer commented Mar 4, 2026

View reviewed changes

crates/stackable-operator/src/databases/drivers/jdbc.rs Outdated Show resolved Hide resolved

sbernauer and others added 2 commits March 19, 2026 09:26

Merge branch 'main' into spike/generic-databases

51cfff6

Improve docs

43730e2

sbernauer requested review from Techassi and removed request for Techassi March 19, 2026 11:45

maltesander moved this from Development: Waiting for Review to Development: In Review in Stackable Engineering Mar 23, 2026

Merge branch 'main' into spike/generic-databases

75efe83

Techassi requested changes Mar 23, 2026

View reviewed changes

maltesander reviewed Mar 25, 2026

View reviewed changes

sbernauer and others added 18 commits March 30, 2026 12:34

Apply suggestions from code review

cb04eb0

Co-authored-by: Malte Sander <malte.sander.it@gmail.com>

refactor!: Take IntoIterator<Item = EnvVar> instead

9fb9d8d

Remove too specific JDBC

0f81de5

JDBC -> Jdbc and SQLAlchemy -> SqlAlchemy

357a288

Update crates/stackable-operator/src/databases/databases/derby.rs

6242c31

Co-authored-by: Techassi <git@techassi.dev>

fix compilation

62c019d

refactor: Let connection_parameters_as_url_query_parameters return Op…

656346b

…tion<String>

Put "org.postgresql.Driver" behind POSTGRES_JDBC_DRIVER_CLASS constant

83907d7

Merge remote-tracking branch 'origin/main' into spike/generic-databases

31cc9f5

refactor: Switch derby location from String to PathBuf

c6bdce6

Clarify what add_to_container does

205d9a5

Remove bullet points

a3d1e6e

Add docs on TemplatingMechanism

8618adf

Rename "databases" module to "database_connections"

d445d37

Explain context(false) and improve error messages

655e4ff

Add TODO on connection param escaping

20ad3e6

Add comment on airflow-op switching to config files

9887e7a

Merge remote-tracking branch 'origin/main' into spike/generic-databases

e92a4ea

sbernauer requested a review from Techassi April 1, 2026 13:28

sbernauer and others added 7 commits April 2, 2026 13:09

Address field name feedback; URI -> URL

f1afb15

Merge branch 'main' into spike/generic-databases

cabe070

Leftovers I forgot to commit

a884e67

Rename env_var_from_secret to env_var_with_value_from_secret

8c8615e

Add comment on snafu error

5f988fc

Move Derby JDBC driver into consant

106dba4

Merge remote-tracking branch 'origin/main' into spike/generic-databases

e9e9011

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

feat: Add generic database connection mechanism#1163

feat: Add generic database connection mechanism#1163
sbernauer wants to merge 49 commits intomainfrom
spike/generic-databases

sbernauer commented Mar 2, 2026 •

edited

Loading

Uh oh!

Uh oh!

Uh oh!

Techassi left a comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Uh oh!

Conversation

sbernauer commented Mar 2, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description

Definition of Done Checklist

Author

Reviewer

Acceptance

Uh oh!

Uh oh!

Uh oh!

Techassi left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

sbernauer commented Mar 2, 2026 •

edited

Loading