Skip to content

feat!: Add mandatory provison_parts argument to SecretOperatorVolumeSourceBuilder::new#1165

Merged
Techassi merged 16 commits intomainfrom
spike/secret-op-volume-request-parts
Apr 2, 2026
Merged

feat!: Add mandatory provison_parts argument to SecretOperatorVolumeSourceBuilder::new#1165
Techassi merged 16 commits intomainfrom
spike/secret-op-volume-request-parts

Conversation

@sbernauer
Copy link
Copy Markdown
Member

@sbernauer sbernauer commented Mar 5, 2026

Description

Part of stackabletech/issues#547

Definition of Done Checklist

  • Not all of these items are applicable to all PRs, the author should update this template to only leave the boxes in that are relevant
  • Please make sure all these things are done and tick the boxes

Author

  • Changes are OpenShift compatible
  • CRD changes approved
  • CRD documentation for all fields, following the style guide.
  • Integration tests passed (for non trivial changes)
  • Changes need to be "offline" compatible

Reviewer

  • Code contains useful comments
  • Code contains useful logging statements
  • (Integration-)Test cases added
  • Documentation added or updated. Follows the style guide.
  • Changelog updated
  • Cargo.toml only contains references to git tags (not specific commits or branches)

Acceptance

  • Feature Tracker has been updated
  • Proper release label has been added

@sbernauer sbernauer changed the title Spike/secret op volume request parts feat!: Add mandatory provison_parts argument to SecretOperatorVolumeSourceBuilder::new Mar 5, 2026
@sbernauer sbernauer marked this pull request as ready for review March 5, 2026 07:51
@Techassi
Copy link
Copy Markdown
Member

Techassi commented Mar 25, 2026

I'm not a huge fan of further removing stuff from secret-operator and have it defined in stackable-operator. This is just the wrong place in my opinion. (This is also noted in my dev comment I added in 899b8e1)

We should seriously consider moving the core operators next to the framework code, and expose library functionality of these core operators as library code owned by these operators.

@Techassi
Copy link
Copy Markdown
Member

Techassi commented Apr 2, 2026

@sbernauer and I decided to move forward with the PR as is and have the enum in two places until we will work on stackabletech/issues#842.

Techassi
Techassi previously approved these changes Apr 2, 2026
@sbernauer
Copy link
Copy Markdown
Member Author

LGTM can be approved and merged

Techassi
Techassi previously approved these changes Apr 2, 2026
@Techassi Techassi enabled auto-merge April 2, 2026 11:32
@Techassi Techassi added this pull request to the merge queue Apr 2, 2026
Merged via the queue into main with commit d4ed55d Apr 2, 2026
5 checks passed
@Techassi Techassi deleted the spike/secret-op-volume-request-parts branch April 2, 2026 12:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants