Correct some Java Warnings by hiveship · Pull Request #1855 · swagger-api/swagger-codegen

hiveship · 2016-01-08T16:34:15Z

Just correct some Java warnings (static methods, useless imports, unused
parameters...). Don't impact any features. Tests are OK.

Just correct some Java warnings (static methods, useless imports, unused parameters...). Don't impact any features. Tests are OK.

Tests OK.

*-SNAPSHOT are only available while using the local source. Refers to the latests on the Maven Central if using distant project.

wing328 · 2016-01-12T14:36:03Z

Thanks for the PR. Instead of using tab, please use 4-space for indentation instead.

I notice that you convert many private instance method into static one. Is that a reason for making that change? Is that based on some Java best practices?

hiveship · 2016-01-12T14:41:18Z

It's a Java Best practice that a method which do not need any instance variable may be declared as static. I only did that on private method since no one will be allow to override it in any other class.
If it make sense to call this method, even if no object has been constructed yet, then it should be static.

wing328 · 2016-01-12T14:44:53Z

Thanks. Do you have the URL to the section in best practice that we can find out more?

hiveship · 2016-01-12T14:51:49Z

I don't have a link to the oracle website yet but:

See the accepted answer: http://stackoverflow.com/questions/11240178/what-is-the-gain-from-declaring-a-method-as-static

generated in Java using "java.util.UUID" class instead of a classical String.

hiveship · 2016-01-14T11:12:08Z

I added a commit to handle UUID generation in a Java code.

…resent. Clean responses mechanism using volley default's

…sions

@see

This last change was producing a wrong swagger spec @see https://github.com/OAI/OpenAPI-Specification/blob/master/versions/2.0.md "The value MUST start with a leading slash (/)"

Inspired by ClojureClientCodegen.java, it is interesting to use projectName from info.title swagger spec to fill up package.json name attribute

io.swagger.models.Info dependency added

projectName was already defined so never overriden.

… options Adds option to use DateTimeOffset to model datetime fields instead of DateTime to allow preservation of timezone information. Modifies ApiClient.ParameterToString to support DateTimeOffset. Also adds sourceFolder option.

A swagger file that contains a definition named "object" compiles into a class named Object. This is technically not a problem as it lives in a different package than java.lang.Object, but this requires the templates to refer to Java's Object using its fully qualified name.

for ApiClient and upgrade OkHttp

Fix #1840

…our-openapi-spec

wing328 · 2016-01-14T16:58:53Z

The change looks reasonable to me after reading the SO link you provided.

@fehguy do you have any concern switching private instance methods to private static methods?

fehguy · 2016-01-14T20:29:47Z

Hi, I can't merge with tabs vs. spaces, it makes it very painful to diff and doesn't follow our coding standards.

The guts of the PR, from the comments, sound fine--but please try to send a PR with just your changes. If formatting is a problem, it's best to send formatting changes in a different PR.

wing328 · 2016-01-15T01:48:29Z

@hiveship seems like there's an issue with "rebase" as the PR contains 60+ commits. Let me know if you need help fixing that (e.g. using cherry-pick with a new branch)

hiveship · 2016-01-15T08:38:22Z

@wing328 Yes, I would appreciate some help to fix that (I'm really new with git & GitHub).

@fehguy Do you have a code formatter (for example for Eclipse) to provide ? or any quick solution to fix my indent problems ?

Added basics files. Compiling, tests OK but not tested yet.

wing328 · 2016-01-15T09:16:42Z

@hiveship please try the following:

git checkout master
git pull upstream master  // assuming upstream is a remote pointing to swagger-api/swagger-codegen.git
git checkout -b fix_java_warnings
git cherry-pick 7891873c6da49726e36159db597a39cf263dcde0

Check the files to confirm the change is present and cherry-pick more commits if needed.

# Conflicts: # modules/swagger-codegen/src/main/java/io/swagger/codegen/languages/PerlClientCodegen.java

# Conflicts: # modules/swagger-codegen/src/main/java/io/swagger/codegen/DefaultCodegen.java # modules/swagger-codegen/src/main/java/io/swagger/codegen/languages/JaxRSServerCodegen.java

hiveship · 2016-01-15T09:54:54Z

@wing328 all failed and now my local project is in a very bad state (can not commit or pull anything). Is there is way to delete all my local project and reclone again ? (without loosing my work ?)

wing328 · 2016-01-15T10:28:55Z

@hiveship no worry. Please don't delete any commit/branch.

I'll create a new branch and cherrypick the following commits this weekend when I've time:
7891873
f8f9066
b8df13a

hiveship · 2016-01-15T10:29:57Z

Can close this PR. Too complicated to extract the commits and revert the original code formatting. I will continue my work on the Apache CXF support and I'll send a new pull request when it's finished. (See my question #1888)

hiveship · 2016-01-15T10:36:52Z

@wing328 if you prefer, I can delete my fork and fork again. I can apply again my changes in a new branch and then ask for a pull request on this branch. I can do the same for my other works;

Support generation of Java UUID Type
Support for JAX-RS Apache CXF

wing328 · 2016-01-15T10:49:48Z

@hiveship well I just want to save you some time in manually applying those changes in a newly-forked repo. I'll leave it up to you on how you would like to proceed.

One suggestion is to create a new branch and avoid making change directly in the master.

hiveship · 2016-01-15T10:52:53Z

Thank you but I think it could be better to apply change is a newly-forked repo since I am working on other features in the codegen, and the problem will be the same for next PR.
I will create separates branches !

hiveship added 3 commits January 8, 2016 17:32

Correct some Java Warnings

7891873

Just correct some Java warnings (static methods, useless imports, unused parameters...). Don't impact any features. Tests are OK.

Merge upstram

b3a8a21

Tests OK.

Specify swagger-codegen-maven-plugin version

f8f9066

*-SNAPSHOT are only available while using the local source. Refers to the latests on the Maven Central if using distant project.

When a property is defined as : "type: string / format:uuid" it's now

b8df13a

generated in Java using "java.util.UUID" class instead of a classical String.

hiveship mentioned this pull request Jan 14, 2016

[Java Client] Types with format are not correctly mapped #1806

Closed

Shyri and others added 20 commits January 14, 2016 12:27

Fixed android-volley-library responses when additionalProperties is p…

b7372dd

…resent. Clean responses mechanism using volley default's

android-volley-library updated android sdk, buildtools and target ver…

78e20ca

…sions

Java client: get/set connect timeout, fix "debugging"

4f7f917

Java jersey2 client: get/set connect timeout

2243ec0

Fixed bug: basePath should not be empty

84c40e7

This last change was producing a wrong swagger spec @see https://github.com/OAI/OpenAPI-Specification/blob/master/versions/2.0.md "The value MUST start with a leading slash (/)"

projectName support to fill package.json template

5c5aa32

Inspired by ClojureClientCodegen.java, it is interesting to use projectName from info.title swagger spec to fill up package.json name attribute

Compilation error fixed

41b3c8c

io.swagger.models.Info dependency added

Update NodeJSServerCodegen.java

631d305

projectName was already defined so never overriden.

CSharp: add support for DateTimeOffset and sourceFolder configuration

6020b6f

Fixed whitespace/tab issues

5e82043

add compile-mono, fix csharp comment

bb54461

fix comment in csharpdonet2.0

b99a873

add new files for c#

cf5162e

add binary support to C# client

896e37a

better filename handling in objectseralizer (php)

8382ec4

Java okhttp-gson: implement the "debugging" option

191462f

for ApiClient and upgrade OkHttp

add test case for objectserializer

dd41034

add auth support to feign library

bea6baf

Fix #1840

cbornet and others added 5 commits January 14, 2016 12:28

add oauth support to feign client

f748b68

fix wrong query param key name

54bc86e

Ruby: fix testing issue of deleting nonexistent pet

d890cec

README.md: Validating your OpenAPI Spec should point to #validating-y…

dd9de18

…our-openapi-spec

Merge remote-tracking branch 'refs/remotes/swagger-api/master'

adc4150

Working on Apache CXF support

0492380

Added basics files. Compiling, tests OK but not tested yet.

hiveship added 3 commits January 15, 2016 10:43

merge upstream

6b6d1d1

Merge remote-tracking branch 'refs/remotes/swagger-api/master'

2539db1

# Conflicts: # modules/swagger-codegen/src/main/java/io/swagger/codegen/languages/PerlClientCodegen.java

Merge branch 'refs/heads/fix_java_warnings'

cc9a0d4

# Conflicts: # modules/swagger-codegen/src/main/java/io/swagger/codegen/DefaultCodegen.java # modules/swagger-codegen/src/main/java/io/swagger/codegen/languages/JaxRSServerCodegen.java

restore normal state

f9f4087

hiveship closed this Jan 15, 2016

hiveship reopened this Jan 15, 2016

hiveship closed this Jan 15, 2016

hiveship mentioned this pull request Jan 15, 2016

fix java warnings #1900

Merged

Conversation

hiveship commented Jan 8, 2016

Uh oh!

wing328 commented Jan 12, 2016

Uh oh!

hiveship commented Jan 12, 2016

Uh oh!

wing328 commented Jan 12, 2016

Uh oh!

hiveship commented Jan 12, 2016

Uh oh!

hiveship commented Jan 14, 2016

Uh oh!

wing328 commented Jan 14, 2016

Uh oh!

fehguy commented Jan 14, 2016

Uh oh!

wing328 commented Jan 15, 2016

Uh oh!

hiveship commented Jan 15, 2016

Uh oh!

wing328 commented Jan 15, 2016

Uh oh!

hiveship commented Jan 15, 2016

Uh oh!

wing328 commented Jan 15, 2016

Uh oh!

hiveship commented Jan 15, 2016

Uh oh!

hiveship commented Jan 15, 2016

Uh oh!

wing328 commented Jan 15, 2016

Uh oh!

hiveship commented Jan 15, 2016

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

10 participants