support TS 4.3 override syntax in class#1541
Merged
kdy1 merged 10 commits intoswc-project:masterfrom Apr 6, 2021
g-plane:ts-4.3-override
Merged
support TS 4.3 override syntax in class#1541kdy1 merged 10 commits intoswc-project:masterfrom g-plane:ts-4.3-override
override syntax in class#1541kdy1 merged 10 commits intoswc-project:masterfrom
g-plane:ts-4.3-override
Conversation
|
@g-plane, just wanted to double check one thing. I saw a commit message "disallow class B {}
class C extends B {
override private constructor() {
super();
}
} |
Contributor
Author
Contributor
Author
|
Let's see how TypeScript team answers: microsoft/TypeScript#43533 . If I'm wrong, I'll update this PR. |
Contributor
Author
|
As this PR of TypeScript: microsoft/TypeScript#43544 , accessibility modifiers must precede |
Contributor
Author
|
microsoft/TypeScript#43533 is closed because microsoft/TypeScript#43544 is merged, so we can go ahead. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reference: https://devblogs.microsoft.com/typescript/announcing-typescript-4-3-beta/#override-and-the-noimplicitoverride-flag