go.mod: bump minimum Go version to 1.23#5302
Open
jakebailey wants to merge 5 commits intotinygo-org:devfrom
Open
go.mod: bump minimum Go version to 1.23#5302jakebailey wants to merge 5 commits intotinygo-org:devfrom
jakebailey wants to merge 5 commits intotinygo-org:devfrom
Conversation
This enables gotypesalias=1 by default, which is needed for generic type aliases to work correctly in go/types.
Contributor
Author
|
Hm, fun, I guess some of tinygo is not |
The wasmimport parameter validation checks for structs.HostLayout fields in struct types. When HostLayout is used through a type alias (e.g., cm.HostLayout = structs.HostLayout), go/types reports the field type as the alias name rather than the underlying type. Use types.Unalias to resolve through the alias chain before comparing.
Member
|
Also: |
Member
|
I would agree that we can bump the minimum version. Anyone else have any feedback before I squash/merge? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Having
go1.22ingo.modcausesgotypesalias=0to be the default, even if the other parts of the toolchain are Go 1.23+ or higher. Bumping the minimum version resolves this, and I added a test.In searching for docs/CI to update, I found one TODO that said it should be done in 1.23+, so, I did that too.
Related: #4894