Fix overflow in duration#1657
Merged
Thomasdezeeuw merged 4 commits intotokio-rs:masterfrom Feb 20, 2023
TethysSvensson:master
Merged
Fix overflow in duration#1657Thomasdezeeuw merged 4 commits intotokio-rs:masterfrom TethysSvensson:master
Thomasdezeeuw merged 4 commits intotokio-rs:masterfrom
TethysSvensson:master
Conversation
Thomasdezeeuw
approved these changes
Feb 19, 2023
Collaborator
Thomasdezeeuw
left a comment
There was a problem hiding this comment.
Could you also fix it for Windows:
Line 231 in 7ed74bf
Contributor
Author
Done |
Thomasdezeeuw
approved these changes
Feb 19, 2023
Contributor
Author
|
@Thomasdezeeuw I've updated the PR to fix some issues encountered by the CI. |
Collaborator
|
Thanks @TethysSvensson |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When trying to wait for
Duration::MAX, mio will panic with an overflow. This is a work-around for that behavior.