Skip to content

Update Contributing instructions to directly open Package.swift with Xcode#718

Merged
fortmarek merged 1 commit intotuist:mainfrom
michaelmcguire:improved-contributing-instructions
Aug 30, 2022
Merged

Update Contributing instructions to directly open Package.swift with Xcode#718
fortmarek merged 1 commit intotuist:mainfrom
michaelmcguire:improved-contributing-instructions

Conversation

@michaelmcguire
Copy link
Contributor

Short description 📝

While working on #717, I saw the contributing instructions were out-of-date and used the deprecated SPM command generate-xcodeproj. I was able to open, compile and test with Xcode's direct SPM compatibility.

Solution 📦

Update instructions to use Xcode directly.

Implementation 👩‍💻👨‍💻

Updated README.md.

…Xcode instead of using deprecated SPM command.
@codecov-commenter
Copy link

Codecov Report

Merging #718 (d0461d3) into main (2ad4d41) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main     #718   +/-   ##
=======================================
  Coverage   84.83%   84.83%           
=======================================
  Files         158      158           
  Lines        9201     9201           
=======================================
  Hits         7806     7806           
  Misses       1395     1395           

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Copy link
Member

@fortmarek fortmarek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot for the contribution @michaelmcguire!

However, instead of updating the docs in README.md, I suggest linking to this page that goes deeper and uses the now-preferred method of editing tuist with tuist.

@michaelmcguire
Copy link
Contributor Author

However, instead of updating the docs in README.md, I suggest linking to this page that goes deeper and uses the now-preferred method of editing tuist with tuist.

@fortmarek Does that make sense for this specific sub-project? I came into this from it's use in bloomberg/xcdiff so I was only interested in opening it up and working with it's tests (not the greater Tuist project).

@fortmarek
Copy link
Member

ahh, I'm sorry, yes, for this project it makes complete sense!

@fortmarek fortmarek merged commit c36d3a8 into tuist:main Aug 30, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants